Skip to content

feat: speedhack toggle cheat #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 4, 2022
Merged

feat: speedhack toggle cheat #449

merged 10 commits into from
Mar 4, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR adds a cheat to drastically increase the player character's movement speed. Pressing the button toggles this mode.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2210

Manual testing scenarios

  1. Start a game and progress to BossRoom scene
  2. Open the cheat window and use the "Toggle Super Speed" button
  3. Your character should now be much faster

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Jan 21, 2022
@LPLafontaineB LPLafontaineB marked this pull request as ready for review January 21, 2022 16:29
fernando-cortez
fernando-cortez reviewed Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fast, for sure. Is it speed-hack-y enough, @pdeschain?

pdeschain
pdeschain reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@pdeschain pdeschain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve after Fernando's comment on adding a const is addressed 👍

fernando-cortez
fernando-cortez previously approved these changes Feb 7, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 7, 2022
@LPLafontaineB LPLafontaineB added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Feb 23, 2022
@LPLafontaineB
Copy link
Contributor Author

Put on hold until the GDC branch is ready

@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Feb 24, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Feb 24, 2022
View reviewed changes
@SamuelBellomo SamuelBellomo added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Feb 24, 2022
Base automatically changed from feature/Add-buttons-to-cheat-window to develop February 28, 2022 19:29
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 3-Good to Merge labels Mar 3, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Mar 3, 2022
View reviewed changes
fernando-cortez
fernando-cortez previously approved these changes Mar 4, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 4, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 3-Good to Merge labels Mar 4, 2022
@LPLafontaineB LPLafontaineB merged commit ac655fa into develop Mar 4, 2022
@LPLafontaineB LPLafontaineB deleted the feature/speedhack branch March 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LukeStampfli LukeStampfli Awaiting requested review from LukeStampfli

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@pdeschain pdeschain

@fernando-cortez fernando-cortez

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @pdeschain @SamuelBellomo @fernando-cortez