Fix/bossroom anim edits #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with the sped up animations
* reduced boss and imp base attack damage (40 -> 30 and 20 -> 15) * reduced rogue dash rampup time (1.3 -> 1) * increased rogue dash range (15 -> 20) * increased boss trample speed (13 -> 18) * increased boss trample knockback speed (6 -> 9) * increased door closing animation speed (-1 -> -1.5)
There was a problem hiding this comment.
The animation is much better now, but I'm not sure what is happening with the 22 other files that are marked as changed for this PR, some of those changes seem to be the same as PR436 that was just merged. Could there have been an issue while branching from it?
Yeah that was weird--I've merged develop into this branch again and that seems to have fixed it, it's now just the one file, the characterset.fbx, marked as changed! |
LPLafontaineB
previously approved these changes
Feb 7, 2022
…fix a self intersecting poly
fernando-cortez
approved these changes
Feb 7, 2022
LPLafontaineB
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This change edits the animation of the mage's mage bolt (attack 1). The change is in the CharacterSet asset. Some keys from the animation were deleted / moved so that the animation plays smoothly at 1.66x speed, the new speed of attack 1 for all characters.
Related Pull Requests
It is branched off of this PR
Issue Number(s) (*)
Jira ticket here
I've tried to capture some recordings here, but it comes across best when in game:
Before:
https://user-images.githubusercontent.com/89089503/152245341-04800e53-a37e-4d29-a8a9-d3abdd7c9f59.mp4
After:
https://user-images.githubusercontent.com/89089503/152245333-83b29ff5-20b8-4573-bf74-1f730d449feb.mp4
As a side note, I played around with editing the animation for the archer attack 1 to make it look less sped up as well, but I wasn't happy with the result. I think a better solution would be playing that animation at a slower speed, maybe with a speed multiplier. This is nitpicky though; it's not as obvious or jittery looking.