feat: code formatting Yamato job and dotnet format project #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
the
1-Needs Review
fernando-cortez
changed the title
|
Chatted with Fernando and the Yamato error seems to be a non-issue. |
SamuelBellomo
approved these changes
Feb 4, 2022
pdeschain
approved these changes
Feb 14, 2022
pdeschain
added
3-Good to Merge
and removed
1-Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Yamato job definition file created for the formatting of code using
dotnet format. The basis of this work can be seen inside Netcode for GameObjects' repo. A custom C# project is also brought over to facilitate quick iteration over multiple projects/packages, something that will likely be included in future jobs.This job is not triggered automatically just yet. A subsequent PR will introduce the triggering Yamato job def. However, this can be triggered manually through Yamato CLI.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2410
Contribution checklist