Skip to content

fix: dotnet format over solution based on project's .editorconfig file #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix: dotnet format over solution based on project's .editorconfig file #465

merged 1 commit into from
Feb 4, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

This PR simply used the dotnet format tool to format the code inside the codebase, according to the format rules specified by the project's .editorconfig file.

It's mostly just noisy removals of whitespaces.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): [MTT-2410](https://jira.unity3d.com/browse/MTT-2410

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 4, 2022
pdeschain
pdeschain approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@pdeschain pdeschain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooh boy 👍

@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 4, 2022
SamuelBellomo
SamuelBellomo approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh gawd

@SamuelBellomo SamuelBellomo merged commit 2e2304f into develop Feb 4, 2022
@SamuelBellomo SamuelBellomo deleted the fix/code-format-pass branch February 4, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@pdeschain pdeschain

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernando-cortez @pdeschain @SamuelBellomo @LPLafontaineB