Skip to content

feat: player architecture ARCHITECTURE.md addition #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 11, 2022
Merged

feat: player architecture ARCHITECTURE.md addition #476

merged 8 commits into from
Mar 11, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Feb 9, 2022 •
edited
Loading

Description (*)

This PR adds a section inside of our Architecture.md detailing the player hierarchy inside of Boss Room.

Readme.md and Architecture.md have also been given a pass to clear out some outdated sections, as well as to include missing documentation (such as mentioning the UTP transport & Relay).

Some referenced code was also cleaned up for style/cleanliness.

Edit: removal of Photon from README.md, ARCHITECTURE.md, and supporting docs.

Issue Number(s) (*)

Fixes issue(s): MTT-2398, MTT-2757

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added the WIP Work In Progress label Feb 9, 2022
SamuelBellomo
SamuelBellomo reviewed Feb 9, 2022
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Feb 9, 2022
View reviewed changes
@fernando-cortez fernando-cortez removed the WIP Work In Progress label Feb 10, 2022
@fernando-cortez fernando-cortez marked this pull request as ready for review February 10, 2022 16:20
@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly labels Feb 10, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 11, 2022
@fernando-cortez fernando-cortez merged commit 9244751 into develop Mar 11, 2022
@fernando-cortez fernando-cortez deleted the feat/player-architecture-architecture-md-addition branch March 11, 2022 22:38
@fernando-cortez fernando-cortez mentioned this pull request Mar 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@s-omeilia-unity s-omeilia-unity Awaiting requested review from s-omeilia-unity

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB @pdeschain