Skip to content

feat: flag to prevent dev and release builds to connect #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Mar 29, 2022
Merged

feat: flag to prevent dev and release builds to connect #482

merged 49 commits into from
Mar 29, 2022

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Feb 15, 2022 •
edited
Loading

Description (*)

This PR adds a flag to the connection payload telling if the game instance is a dev build or not. The connection approval then uses it to deny connections with different values for that flag. Then, they get an error message telling them they are using incompatible build types.
This PR also simplifies and clarifies the connection approval flow.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2521

Manual testing scenarios

  1. Start a host in editor or in a dev build
  2. Try to join as a client in a release build
  3. See the error
  4. The reverse scenario should also produce the same error

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added the 1-Needs Review PR needs attention from the assignee and reviewers label Feb 15, 2022
fernando-cortez
fernando-cortez reviewed Feb 15, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 15, 2022
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 2-Reviewed with Comments PR requires owner's attention labels Feb 22, 2022
@LPLafontaineB LPLafontaineB mentioned this pull request Mar 7, 2022
Merged
4 tasks
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) March 7, 2022 19:49
@LPLafontaineB LPLafontaineB disabled auto-merge March 7, 2022 19:50
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) March 7, 2022 19:50
@LPLafontaineB LPLafontaineB requested a review from pdeschain March 21, 2022 18:42
@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 21, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Mar 21, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Mar 29, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB disabled auto-merge March 29, 2022 19:25
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 29, 2022
@LPLafontaineB LPLafontaineB merged commit 56f6bd8 into develop Mar 29, 2022
@LPLafontaineB LPLafontaineB deleted the feature/isdebug-flag-for-connection-approval branch March 29, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@SamuelBellomo SamuelBellomo

@fernando-cortez fernando-cortez

Labels
3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @SamuelBellomo @fernando-cortez @netcode-ci-service