chore: adding project ID leak detect #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBellomo
requested review from
fernando-cortez,
pdeschain and
LPLafontaineB
SamuelBellomo
changed the title
SamuelBellomo
added
1-Needs Review
LPLafontaineB
approved these changes
Mar 1, 2022
SamuelBellomo
added
2-One More Review
fernando-cortez
approved these changes
Mar 9, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
SamuelBellomo
added a commit
that referenced
this pull request
Mar 9, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Mar 10, 2022
…I-stats * release/GDC2022: added IP button to main menu (#535) fix: postgame menu button (#523) chore: adding leak detect (#492) Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534) Filled in some holes in the floor (#527) (#533) fix: populate lobby room name if creation room input field is empty (#522) lobby fix: Adding instructions when we get a service error on conflicting joins (#511) feat: auto reconnect (#513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Adding leak detection action for project ID.
This depends on slack bot for sending notifications to our private project channel.
Manual testing scenarios
Tested in private channel adding and removing a project ID, got slack notif when project ID was detected.
Contribution checklist