Skip to content

feat: IP connection window inside main menu (#502) #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

Cherry pick of 502.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

* ip connection window inside main menu

* removing IPUIMediator's connection message publishing

* removing IP from lobby flow (so relay is now default)
@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 4, 2022
@SamuelBellomo SamuelBellomo merged commit d26d8e6 into release/GDC2022 Mar 4, 2022
@SamuelBellomo SamuelBellomo deleted the feature/gdc-ip-window branch March 4, 2022 20:10
SamuelBellomo added a commit that referenced this pull request Mar 8, 2022
…ocal

* release/GDC2022:
  Cherrypick: bigger floor tiles, bossroom.unity scene merge conflict resolved with unity merge tool (#519)
  Cherrypick: lobby visual rework, mainmenu.unity scene merge conflict resolved with unity merge tool (#520)
  cherrypick: Boss and run VFX Optimizations (#514) (#521)
  feat: loading screen (GDC version) (#495)
  fix: client writing to NetworkVariable inside ServerCharacterMovement (#517)
  fix: imps spawning issues when late joining (#497)
  Adding handling of host disconnect (#486) (#509)
  fix: NREs when trying to quit (#516)
  hack fix: disabling client side rate limiting for GDC, real fix should come on develop (#500)
  fix: NetworkAnimator being called on clients (#512)
  fix: username changing before game (#499)
  feat: IP connection window inside main menu (#502) (#508)

# Conflicts:
#	Assets/BossRoom/Scenes/Startup.unity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants