Skip to content

fix: populate lobby room name if creation room input field is empty #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2022
Merged

fix: populate lobby room name if creation room input field is empty #522

merged 3 commits into from
Mar 9, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 8, 2022 •
edited
Loading

Description (*)

Before sending a lobby create request, the lobby name will be populated with a default room name string.

Issue Number(s) (*)

Fixes issue(s): MTT-2748

Manual testing scenarios

  1. Create a lobby without populating the name input field with any characters.
  2. Lobby will be created and will jump to CharSelect scene.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers 0-workaround labels Mar 8, 2022
SamuelBellomo
SamuelBellomo reviewed Mar 8, 2022
View reviewed changes
@fernando-cortez fernando-cortez changed the title fix: generate a random room key if creation room input field is blank fix: populate lobby room name if creation room input field is blank Mar 8, 2022
@fernando-cortez fernando-cortez changed the title fix: populate lobby room name if creation room input field is blank fix: populate lobby room name if creation room input field is empty Mar 8, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 8, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 9, 2022
@fernando-cortez fernando-cortez merged commit 2a833a7 into release/GDC2022 Mar 9, 2022
@fernando-cortez fernando-cortez deleted the fix/random-lobby-room-name branch March 9, 2022 14:54
fernando-cortez added a commit that referenced this pull request Mar 9, 2022
@fernando-cortez
fix: populate lobby room name if creation room input field is empty (#…
ffd5e89 
…522)
@fernando-cortez fernando-cortez mentioned this pull request Mar 9, 2022
Merged
4 tasks
SamuelBellomo pushed a commit that referenced this pull request Mar 9, 2022
@fernando-cortez
fix: populate lobby room name if creation room input field is empty (#…
cee7c1a 
…522) (#524)
SamuelBellomo added a commit that referenced this pull request Mar 10, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/adding-transport-RTT-to-U…
761c691 
…I-stats

* release/GDC2022:
  added IP button to main menu (#535)
  fix: postgame menu button (#523)
  chore: adding leak detect (#492)
  Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534)
  Filled in some holes in the floor (#527) (#533)
  fix: populate lobby room name if creation room input field is empty (#522)
  lobby fix: Adding instructions when we get a service error on conflicting joins (#511)
  feat: auto reconnect (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees

@SamuelBellomo SamuelBellomo

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB