Skip to content

fix: populate lobby room name if creation room input field is empty (#522) #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix: populate lobby room name if creation room input field is empty (#522) #524

merged 1 commit into from
Mar 9, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

Cherry pick of 522.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@SamuelBellomo SamuelBellomo merged commit cee7c1a into develop Mar 9, 2022
@SamuelBellomo SamuelBellomo deleted the fix/default-lobby-name branch March 9, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees

@SamuelBellomo SamuelBellomo

@LPLafontaineB LPLafontaineB

Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB