feat: display popup when failing to connect to full lobby #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full-popup # Conflicts: # Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyUIMediator.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/LobbyAPIInterface.cs
LukeStampfli
added
GDC-cherrypick
1-Needs Review
LukeStampfli
commented
Mar 9, 2022
fernando-cortez
added
2-Reviewed with Comments
…full-popup # Conflicts: # Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs
|
Merged with Phil's changes. I moved the lobby related stuff out into a separate function to keep things a bit more readable (wanted to avoid nested switches). |
LukeStampfli
added
1-Needs Review
fernando-cortez
approved these changes
Mar 15, 2022
SamuelBellomo
approved these changes
Mar 15, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
SamuelBellomo
added
the
0-URGENT
LukeStampfli
added a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit 18566e3)
SamuelBellomo
pushed a commit
that referenced
this pull request
Mar 16, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Mar 17, 2022
…i-turned-off * release/GDC2022: feat: better lobby exceptions handling (#568) fix: updaterunner item already added (#565) Added empty lobby list text label and code to drive it's visibility (#567) feat: display popup when failing to connect to full lobby (#525) Darker Eyebrows for Player Characters (#555) (#564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added a feature to display a popup to the user when they fail to join a lobby because it is full.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2646
Manual testing scenarios
Contribution checklist