Skip to content

feat: Adding transport rtt to UI stats #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SamuelBellomo
Copy link
Contributor

Description (*)

It was commented that RTT seemed high. Adding UTP side RTT to trigger conversation and show the difference.

Issue Number(s) (*)

MTT-2778

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…I-stats

* release/GDC2022:
  lobby fix: Removing quit when lobby detects host left. (#505)
  Cherrypick: bigger floor tiles, bossroom.unity scene merge conflict resolved with unity merge tool (#519)
  Cherrypick: lobby visual rework, mainmenu.unity scene merge conflict resolved with unity merge tool (#520)
  cherrypick: Boss and run VFX Optimizations (#514) (#521)
  feat: loading screen (GDC version) (#495)
  fix: client writing to NetworkVariable inside ServerCharacterMovement (#517)
  fix: imps spawning issues when late joining (#497)
  Adding handling of host disconnect (#486) (#509)
  fix: NREs when trying to quit (#516)
  hack fix: disabling client side rate limiting for GDC, real fix should come on develop (#500)
  fix: NetworkAnimator being called on clients (#512)
  fix: username changing before game (#499)
@SamuelBellomo SamuelBellomo added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 9, 2022
@SamuelBellomo SamuelBellomo changed the title Sam/fix/adding transport rtt to UI stats feat: Adding transport rtt to UI stats Mar 9, 2022
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks aside, lgtm

@LPLafontaineB LPLafontaineB added the 2-Reviewed with Comments PR requires owner's attention label Mar 9, 2022
…I-stats

* release/GDC2022:
  added IP button to main menu (#535)
  fix: postgame menu button (#523)
  chore: adding leak detect (#492)
  Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534)
  Filled in some holes in the floor (#527) (#533)
  fix: populate lobby room name if creation room input field is empty (#522)
  lobby fix: Adding instructions when we get a service error on conflicting joins (#511)
  feat: auto reconnect (#513)
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) March 10, 2022 22:37
@SamuelBellomo SamuelBellomo removed the 2-Reviewed with Comments PR requires owner's attention label Mar 10, 2022
@SamuelBellomo SamuelBellomo requested a review from pdeschain March 11, 2022 19:58
@SamuelBellomo SamuelBellomo merged commit 215d979 into release/GDC2022 Mar 11, 2022
@SamuelBellomo SamuelBellomo deleted the sam/fix/adding-transport-RTT-to-UI-stats branch March 11, 2022 21:45
SamuelBellomo added a commit that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly GDC-cherrypick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants