Skip to content

fix: added IP button to main menu #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

Added a "Direct IP" button directly to main menu. This now lets users know how to connect via IP.

Issue Number(s) (*)

Fixes issue(s): MTT.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 9, 2022
LPLafontaineB
LPLafontaineB previously approved these changes Mar 9, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Mar 9, 2022
@SamuelBellomo SamuelBellomo added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers and removed 3-Good to Merge labels Mar 9, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 9, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 10, 2022
@fernando-cortez fernando-cortez merged commit b956e5d into release/GDC2022 Mar 10, 2022
@fernando-cortez fernando-cortez deleted the fix/IP-button-mainmenu branch March 10, 2022 14:09
@fernando-cortez fernando-cortez mentioned this pull request Mar 10, 2022
4 tasks
SamuelBellomo added a commit that referenced this pull request Mar 10, 2022
…I-stats

* release/GDC2022:
  added IP button to main menu (#535)
  fix: postgame menu button (#523)
  chore: adding leak detect (#492)
  Cherry pick: lobby blue banner fix, mainmenu.unity scene merge conflict resolved with unity merge tool (#534)
  Filled in some holes in the floor (#527) (#533)
  fix: populate lobby room name if creation room input field is empty (#522)
  lobby fix: Adding instructions when we get a service error on conflicting joins (#511)
  feat: auto reconnect (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants