Skip to content

fix: simpler quitting flow #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 11, 2022
Merged

fix: simpler quitting flow #537

merged 10 commits into from
Mar 11, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR simplifies the condition in QuitPanel so that now it quits/sends to menu depending on the current active scene.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2800

Manual testing scenarios

  1. Try quitting from the main menu and from any other scene
  2. See that in main menu the application quits while in other scenes you return to main menu

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 10, 2022
@LPLafontaineB LPLafontaineB requested a review from pdeschain March 10, 2022 17:36
pdeschain
pdeschain previously approved these changes Mar 10, 2022
View reviewed changes
@pdeschain pdeschain added the 2-One More Review One review in, one to go label Mar 10, 2022
fernando-cortez
fernando-cortez previously approved these changes Mar 10, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 10, 2022
@LPLafontaineB LPLafontaineB dismissed stale reviews from fernando-cortez and pdeschain via ddce2a2 March 10, 2022 19:22
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 11, 2022
@LPLafontaineB LPLafontaineB merged commit 0477006 into release/GDC2022 Mar 11, 2022
@LPLafontaineB LPLafontaineB deleted the fix/simpler-quitting-flow branch March 11, 2022 14:19
@LPLafontaineB LPLafontaineB mentioned this pull request Mar 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
0-workaround 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @pdeschain @SamuelBellomo @fernando-cortez