fix: arrow ClientRpc error #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
LPLafontaineB
approved these changes
Mar 15, 2022
SamuelBellomo
approved these changes
Mar 15, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
fernando-cortez
added a commit
that referenced
this pull request
Mar 15, 2022
Merged
4 tasks
SamuelBellomo
pushed a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
A ClientRpc was invoked on an arrow when it was despawned. This PR prevents that from happening.
Additionally, a quick fix has been added to reset the VFX of the arrow, specifically the TrailRenderer, when it is spawned/despawned.
Issue Number(s) (*)
Fixes issue(s): MTT-2835
Manual testing scenarios
Reproducing the ClientRpc error can be quite a challenge, but spamming arrows with the archer should produce consistent trails and no errors.
Contribution checklist