Skip to content

fix: nullref on host when disconnecting #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix: nullref on host when disconnecting #558

merged 1 commit into from
Mar 16, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR simply adds IsClosingClients to the condition for loading a scene offline vs online in SceneLoaderWrapper.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2832

Manual testing scenarios

  1. Start hosting a game
  2. Return to main menu via the quit button
  3. See no null refs anymore

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers 0-workaround labels Mar 15, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 15, 2022
@LPLafontaineB LPLafontaineB merged commit 3629a0d into release/GDC2022 Mar 16, 2022
@LPLafontaineB LPLafontaineB deleted the fix/nullref-on-host-when-disconnecting branch March 16, 2022 14:34
SamuelBellomo added a commit that referenced this pull request Mar 16, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/disconnect-issue-with-wif…
868ae04 
…i-turned-off

* release/GDC2022:
  Added IsClosingClients to condition for loading offline vs online in SceneLoaderWrapper (#558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@pdeschain pdeschain Awaiting requested review from pdeschain

@LukeStampfli LukeStampfli Awaiting requested review from LukeStampfli

Assignees
No one assigned
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 0-workaround 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LPLafontaineB @SamuelBellomo @fernando-cortez