Skip to content

fix: RTT text too small #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: RTT text too small #559

merged 1 commit into from
Mar 15, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

This fixes the sizing issue on the RTT text above the Client/Server type text. Text has also been converted to TMPro components.

Issue Number(s) (*)

Fixes issue(s): MTT-2831

Manual testing scenarios

  1. Host/Join game and read text on bottom left of screen.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 15, 2022
@fernando-cortez fernando-cortez merged commit 5ed69dd into release/GDC2022 Mar 15, 2022
@fernando-cortez fernando-cortez deleted the fix/RTT-text-too-small branch March 15, 2022 22:22
fernando-cortez added a commit that referenced this pull request Mar 15, 2022
@fernando-cortez
type and rtt text is now TextMeshPro and sized properly (#559)
59325d6
@fernando-cortez fernando-cortez mentioned this pull request Mar 15, 2022
Merged
4 tasks
SamuelBellomo pushed a commit that referenced this pull request Mar 15, 2022
@fernando-cortez
type and rtt text is now TextMeshPro and sized properly (#559) (#561)
5356e3c
SamuelBellomo added a commit that referenced this pull request Mar 16, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/disconnect-issue-with-wif…
93459d2 
…i-turned-off

* release/GDC2022:
  type and rtt text is now TextMeshPro and sized properly (#559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees

@SamuelBellomo SamuelBellomo

@LPLafontaineB LPLafontaineB

Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB