Skip to content

fix: null refs preventing users from quitting #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: null refs preventing users from quitting #563

merged 1 commit into from
Mar 17, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR simply adds a try/catch to LeaveBeforeQuit to make sure that we quit even if exceptions happen.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2656

Manual testing scenarios

Sadly, we haven't found repro steps to MTT-2656

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 16, 2022
@LPLafontaineB
Copy link
Contributor Author

Not sure if this should be marked as a workaround or if this should be later cherrypicked to develop. What do you think?

@SamuelBellomo
Copy link
Contributor

added the cherrypick label

pdeschain
pdeschain approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@pdeschain pdeschain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed during standup!

@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 16, 2022
@LPLafontaineB LPLafontaineB merged commit eecfe7e into release/GDC2022 Mar 17, 2022
@LPLafontaineB LPLafontaineB deleted the fix/null-refs-preventing-from-quitting branch March 17, 2022 19:58
LPLafontaineB added a commit that referenced this pull request Mar 17, 2022
@LPLafontaineB
Adding try/catch to LeaveBeforeQuit to make sure that we quit even if…
a948446 
… exceptions happen (#563)

(cherry picked from commit eecfe7e)
@LPLafontaineB LPLafontaineB mentioned this pull request Mar 17, 2022
Merged
4 tasks
SamuelBellomo pushed a commit that referenced this pull request Mar 17, 2022
@LPLafontaineB
cherrypick fix: null refs when quitting (#563) (#572)
84cb5d3 
* Adding try/catch to LeaveBeforeQuit to make sure that we quit even if exceptions happen (#563)

(cherry picked from commit eecfe7e)

* Removed unneeded ForceLeaveLobbyAttempt and unneeded return types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez left review comments

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @SamuelBellomo @pdeschain @fernando-cortez