fix: updaterunner item already added #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeschain
added
2-Easy
pdeschain
changed the title
SamuelBellomo
approved these changes
Mar 16, 2022
fernando-cortez
approved these changes
Mar 17, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
LPLafontaineB
approved these changes
Mar 17, 2022
pdeschain
added a commit
that referenced
this pull request
Mar 17, 2022
* Added guarding in update runner * swapped for a slightly more performant check
SamuelBellomo
added a commit
that referenced
this pull request
Mar 17, 2022
…i-turned-off * release/GDC2022: feat: better lobby exceptions handling (#568) fix: updaterunner item already added (#565) Added empty lobby list text label and code to drive it's visibility (#567) feat: display popup when failing to connect to full lobby (#525) Darker Eyebrows for Player Characters (#555) (#564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added guarding that would prevent us from having an error when adding multiple instances of the same callback to the UpdateRunner. Previously it was possible to slip in such an operation.
Related Pull Requests
Issue Number(s) (*)
MTT-2838
Fixes issue(s):
MTT-2838
Manual testing scenarios
Questions or comments
Contribution checklist