Skip to content

feat: better lobby exception handling [MTT-2649] #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 6, 2022
Merged

feat: better lobby exception handling [MTT-2649] #585

merged 11 commits into from
Apr 6, 2022

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Mar 29, 2022 •
edited
Loading

Description

This PR is mostly a cherrypick of #568, which restricted popup messages to only some lobby exceptions and removed an unnecessary call to check if a player was part of a lobby before trying to kick them.

On top of the cherrypick, I replaced the handling of 400 bad request which from my earlier tests happened when we tried to input a badly formatted user-code with ValidationError which is the exception reason we receive now.

Issue Number(s)

MTT-2649 and MTT-2840

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 29, 2022
pdeschain
pdeschain previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@pdeschain pdeschain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 29, 2022
fernando-cortez
fernando-cortez reviewed Mar 29, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 2-One More Review One review in, one to go labels Mar 29, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Mar 29, 2022
@LPLafontaineB LPLafontaineB requested a review from pdeschain March 29, 2022 20:23
SamuelBellomo
SamuelBellomo reviewed Mar 29, 2022
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Mar 29, 2022
View reviewed changes
SamuelBellomo
SamuelBellomo previously approved these changes Mar 29, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Mar 30, 2022
@LPLafontaineB
Copy link
Contributor Author

Putting on hold temporarily, just waiting for some feedback from the lobby team

@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 2-One More Review One review in, one to go labels Apr 4, 2022
pdeschain
pdeschain requested changes Apr 5, 2022
View reviewed changes
@pdeschain pdeschain added the 2-Reviewed with Comments PR requires owner's attention label Apr 5, 2022
@LPLafontaineB LPLafontaineB requested a review from pdeschain April 5, 2022 16:22
fernando-cortez
fernando-cortez reviewed Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve once comments are addressed 👍.

@LPLafontaineB LPLafontaineB removed the 2-Reviewed with Comments PR requires owner's attention label Apr 5, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Apr 5, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 6, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Apr 6, 2022
View reviewed changes
pdeschain
pdeschain previously approved these changes Apr 6, 2022
View reviewed changes
@pdeschain pdeschain added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Apr 6, 2022
@LPLafontaineB LPLafontaineB dismissed stale reviews from pdeschain and SamuelBellomo via 514b3cb April 6, 2022 21:10
@LPLafontaineB LPLafontaineB merged commit 152448e into develop Apr 6, 2022
@LPLafontaineB LPLafontaineB deleted the feature/better-exception-handling branch April 6, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez left review comments

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@pdeschain pdeschain

@fernando-cortez fernando-cortez

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @pdeschain @SamuelBellomo @fernando-cortez