fix: fixing issue with iOS black screen where message queue constructor would get stripped out [MTT-2663] #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to dynamically spawn message queues using reflection, we're now instantiating them manually in application controller. This way, they won't get stripped out by IL2CPP's code stripping (which can't be deactivated). Another solution could have been to use ref types for messages instead of value types, since those won't get stripped in generic types. However this creates allocations each time we're sending a message internally.
SamuelBellomo
requested review from
pdeschain,
fernando-cortez and
LPLafontaineB
SamuelBellomo
added
0-URGENT
pdeschain
approved these changes
Apr 6, 2022
LPLafontaineB
approved these changes
Apr 6, 2022
LPLafontaineB
added
3-Good to Merge
and removed
1-Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of trying to dynamically spawn message queues using reflection, we're now instantiating them manually in application controller. This way, they won't get stripped out by IL2CPP's code stripping (which can't be deactivated).
Another solution could have been to use ref types for messages instead of value types, since those won't get stripped in generic types. However this creates allocations each time we're sending a message internally which is no bueno.
Issue Number(s)
MTT-2663
Contribution checklist