fix: arrow despawned rpc [MTT-3134] #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
LPLafontaineB
approved these changes
Apr 6, 2022
LPLafontaineB
added
2-One More Review
SamuelBellomo
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without repro steps for the attached ticket, this PR should address the issue for RPCs sent from an arrow on the host. Basically, OnNetworkDespawn() never cleared a flag that prevented any FixedUpdate() logic, thus potentially sending an RPC on a despawned object. This has now been taken care of and will be extensively tested in next test session.
Issue Number(s)
[MTT](https://jira.unity3d.com/browse/MTT-3134)
Contribution checklist