Skip to content

feat: structure refactor (3) gameplay and infrastructure cleanup [MTT-2623] #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

feat: structure refactor (3) gameplay and infrastructure cleanup [MTT-2623] #672

wants to merge 12 commits into from

Conversation

pdeschain
Copy link
Contributor

Description

This PR further change Gameplay and Infrastructure folders.

Issue Number(s)

MTT-2623

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

pdeschain and others added 12 commits May 31, 2022 16:51
@pdeschain
Moved files, created new asmdefs, decoupled systems via messaging
c8afb10
@pdeschain
switched all asmdefs to use GUIDs for better durability when refactoring
05d753b
@pdeschain
simplified very long asmdef names
57158cf
@pdeschain
code standards pass
78b9a0e
@pdeschain
code standards #
66dd344
@pdeschain
uniform Unity.BossRoom._ naming for asmdefs
65eca8c
@pdeschain
folder rearrangement and rename
5f7519c
@SamuelBellomo
Update Assets/BossRoom/Scripts/ApplicationLifecycle/ApplicationContro…
a5850fd 
…ller.cs
@pdeschain
Merge branch 'develop' into pdeschain/structure-refactor-1-asmdefs-an…
215d75b 
…d-folder-changes

# Conflicts:
#	Assets/BossRoom/Scripts/Gameplay/ConnectionManagement/ClientGameNetPortal.cs
@pdeschain
bossroom folder removed
2bb867e
@pdeschain
Infrastructure and Gameplay folder and assembly refactor
af7cc1a
@pdeschain
added reference to utils asmdef from applicationcontroller.asmdef
8009a06
@pdeschain pdeschain added the 1-Needs Review PR needs attention from the assignee and reviewers label Jun 1, 2022
@pdeschain pdeschain requested a review from SamuelBellomo as a code owner June 1, 2022 20:21
@pdeschain pdeschain changed the title feat: structure refactor 3 gameplay and infrastructure cleanup [MTT-2623] feat: structure refactor (3) gameplay and infrastructure cleanup [MTT-2623] Jun 1, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Jun 2, 2022
LPLafontaineB
LPLafontaineB reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should NetworkedCharacterState, NetworkedLifeState and PublishMessageOnLifeChange be moved to the Character folder? Or maybe PublishMessageOnLifeChange could be moved to the Messages folder?

Base automatically changed from pdeschain/structure-refactor-2-remove-bossroom-folder to develop June 2, 2022 17:03
@pdeschain pdeschain closed this Jun 2, 2022
@pdeschain pdeschain mentioned this pull request Jun 2, 2022
Merged
6 tasks
@pdeschain pdeschain deleted the pdeschain/structure-refactor-3-gameplay-and-infrastructure-cleanup branch October 4, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB left review comments

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees
No one assigned
Labels
3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdeschain @SamuelBellomo @fernando-cortez @LPLafontaineB