Skip to content

fix: restoring lobby heartbeat [MTT-4210] #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix: restoring lobby heartbeat [MTT-4210] #703

merged 1 commit into from
Aug 2, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description

Fix to re-introduce lobby heartbeats such that lobby owners push lobby data on update intervals & non-owners receive individual lobby updates on said intervals. This resolves lobbies being destroyed on their own since data was not being pushed up to the service.

Issue Number(s)

MTT-4210

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly labels Aug 1, 2022
@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 2, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Aug 2, 2022
@fernando-cortez fernando-cortez merged commit cae91fa into develop Aug 2, 2022
@fernando-cortez fernando-cortez deleted the fix/restoring-lobby-heartbeat branch August 2, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@pdeschain pdeschain

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @pdeschain @LPLafontaineB