Skip to content

feat: returning to offline state on transport failure [MTT-4302] #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 24, 2022
Merged

feat: returning to offline state on transport failure [MTT-4302] #707

merged 8 commits into from
Aug 24, 2022

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Aug 9, 2022 •
edited
Loading

Description

This PR adds handling to the OnTransportFailure callback. When it is invoked, the ConnectionManager will return to the Offline state so that it can restart hosting again.

Issue Number(s)

MTT-4302

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 9, 2022
@LPLafontaineB LPLafontaineB requested a review from pdeschain August 9, 2022 18:01
SamuelBellomo
SamuelBellomo reviewed Aug 9, 2022
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Aug 10, 2022
View reviewed changes
SamuelBellomo
SamuelBellomo previously approved these changes Aug 10, 2022
View reviewed changes
pdeschain
pdeschain previously approved these changes Aug 11, 2022
View reviewed changes
@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 11, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Aug 15, 2022
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 3-Good to Merge labels Aug 23, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 23, 2022
pdeschain
pdeschain previously approved these changes Aug 24, 2022
View reviewed changes
@pdeschain pdeschain added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Aug 24, 2022
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 3-Good to Merge labels Aug 24, 2022
@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 24, 2022
@LPLafontaineB LPLafontaineB merged commit b449a4d into develop Aug 24, 2022
@LPLafontaineB LPLafontaineB deleted the feature/on-transport-failure-handling branch August 24, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @pdeschain @SamuelBellomo @fernando-cortez