Skip to content

feat: bumping boss room to 1.1 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 25, 2022
Merged

feat: bumping boss room to 1.1 #708

merged 28 commits into from
Oct 25, 2022

Conversation

SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Aug 10, 2022 •
edited
Loading

Description

Update BR to NGO 1.1.0 and following latest good practices with new available APIs.

Changes with NGO 1.1.0

  • use managed types for netvars? For Network GUID?
  • Cleanup Relay and UTP setup? see PR that simplifies setup flow
  • Cleanup MaxSendQueueSize value from serialized as it's been removed?
  • Revert default value for max payload size
  • Set connection approval timeout higher, 1 sec is pretty short. If there's a packet drop, some hangups on the network, clients would get timedout too easily.

Contribution checklist

  • n/a Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • n/a JIRA ticket ID is in the PR title or at least one commit message
  • n/a Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Sep 23, 2022
@SamuelBellomo SamuelBellomo mentioned this pull request Oct 5, 2022
Merged
@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Oct 6, 2022
@SamuelBellomo
Merge branch 'develop' into sam/feat/bump-NGO-to-1.1
c13ba78 
* develop: (60 commits)
  fix: removing FindObjectOfType for a serialized reference (#754)
  fix: can click through loading screen [MTT-4753] (#760)
  Update CHANGELOG.md (#765)
  feat: Architecture.md update (MTT-2637) (#763)
  Update README.md (#759)
  Updating utilities package for release (#764)
  Version bumps (#761)
  Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758)
  adding components refs to index (#757)
  Adding link to feedback form at the top (#756)
  chore: adding details to changelog (#746)
  Updating readme with Typeform for feedback (#755)
  made arrow trails smaller (#750)
  Fixed up some layer settings on some archer VFX so that they show up properly! (#739)
  fix: lobby UI unblocking before it should [MTT-4579] (#748)
  feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612)
  Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753)
  fix: Moving utp to component instead of child GameObject (#752)
  Adding TOC and index to readme [MTT-4617] (#736)
  Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751)
  ...

# Conflicts:
#	Assets/Prefabs/NetworkingManager.prefab
@SamuelBellomo
basis works, still need to debug issue with client reconnecting a sec…
2a69af7 
…ond time
@SamuelBellomo
setting back max payload size to default value. With recent changes, …
29d79b8 
…this now only applies to unreliable messages. With how little NGO uses unreliable messages, this shouldn't need any tweaking anymore.

reserializing NetworkingManager, this removes the old max send queue size value as well.
@SamuelBellomo
Increasing connection approval timeout to 5 seconds, as 1 second was …
2b50fd9 
…pretty short for a connection. If there's any packet drops or temporary lag spike, this could timeout the connection when it was actually fine. Still lower than the default 10 seconds.
@SamuelBellomo
making diff clearer for review
59ab475
@SamuelBellomo
adding better exception error
d3f59da
@SamuelBellomo
using classes instead of structs now that we have managed types avail…
5bb2994 
…able in netvars
@SamuelBellomo
Merge branch 'develop' into sam/feat/bump-NGO-to-1.1
ab1174b
@SamuelBellomo
fixing null ref when doing reconnection flow
2913b23
@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Oct 19, 2022
@SamuelBellomo SamuelBellomo marked this pull request as ready for review October 19, 2022 20:22
@LPLafontaineB LPLafontaineB added the 2-Reviewed with Comments PR requires owner's attention label Oct 19, 2022
@SamuelBellomo
removing useless usings
b6705f4
@SamuelBellomo
Merge branch 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technolog…
864fead 
…ies/com.unity.multiplayer.samples.coop into sam/feat/bump-NGO-to-1.1

* 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop:
  adding missing PR ID
  adding missing PR ID
  Fix: Moved Clipping Torch (#768)
@SamuelBellomo
namespace adjustements
2fe2683
LPLafontaineB
LPLafontaineB previously approved these changes Oct 20, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Oct 20, 2022
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) October 20, 2022 19:28
@SamuelBellomo SamuelBellomo removed the 2-One More Review One review in, one to go label Oct 20, 2022
LPLafontaineB
LPLafontaineB previously approved these changes Oct 20, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 20, 2022
ashwinimurt
ashwinimurt previously approved these changes Oct 20, 2022
View reviewed changes
pdeschain
pdeschain previously approved these changes Oct 20, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB dismissed stale reviews from pdeschain, ashwinimurt, and themself via 521c019 October 24, 2022 18:39
@SamuelBellomo
fixing player prefab being destroyed issue
48573dd
@SamuelBellomo
Merge branch 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technolog…
2cebbd2 
…ies/com.unity.multiplayer.samples.coop into sam/feat/bump-NGO-to-1.1

* 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop:
  initializing number of reconnect attempts before starting the reconnect coroutine
@SamuelBellomo SamuelBellomo merged commit 06f66c1 into develop Oct 25, 2022
@SamuelBellomo SamuelBellomo deleted the sam/feat/bump-NGO-to-1.1 branch October 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@pdeschain pdeschain pdeschain left review comments

@ashwinimurt ashwinimurt ashwinimurt left review comments

@simon-lemay-unity simon-lemay-unity simon-lemay-unity left review comments

Assignees
No one assigned
Labels
2-One More Review One review in, one to go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamuelBellomo @pdeschain @ashwinimurt @simon-lemay-unity @LPLafontaineB @netcode-ci-service