fix: lobby UI unblocking before it should [MTT-4579] #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPLafontaineB
added
2-Easy
SamuelBellomo
approved these changes
Sep 28, 2022
SamuelBellomo
added
the
0-URGENT
LPLafontaineB
added
2-One More Review
fernando-cortez
approved these changes
Sep 29, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
SamuelBellomo
added a commit
that referenced
this pull request
Oct 13, 2022
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents unblocking the lobby UI during periodic queries. These still happen while we are attempting to join a lobby and connect to a Relay server. If the joining and connection take a lot of time, a periodic query can happen before they are done, which would unblock the UI and allow the user to try to join a lobby again. To prevent this, this PR now simply does not unblock the UI after those periodic queries, which is not necessary anyways because periodic queries do not block the UI.
Issue Number(s)
MTT-4579
Contribution checklist