Skip to content

Updating readme with Typeform for feedback #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chrispope
Copy link
Collaborator

@chrispope chrispope commented Sep 30, 2022

Updating readme with Typeform for feedback. Adding to the TOC and placement of form at the end of readme. Might cause visibility issues due to placement. Open to suggestions.

Description

Issue Number(s)

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

Updating readme with Typeform for feedback - adding to the TOC and placement of form at the end of readme. Might cause visibility issues due to placement. Open to suggestions.
@chrispope chrispope self-assigned this Sep 30, 2022
@chrispope chrispope added the 2-Easy This PR is trivial and can be reviewed quickly label Sep 30, 2022
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Oct 3, 2022
fernando-cortez
fernando-cortez previously approved these changes Oct 3, 2022
@LPLafontaineB LPLafontaineB added the 2-One More Review One review in, one to go label Oct 3, 2022
@SamuelBellomo SamuelBellomo merged commit b27143d into develop Oct 4, 2022
@SamuelBellomo SamuelBellomo deleted the chrispope-Updating-readme-with-Typeform-for-feedback branch October 4, 2022 13:57
SamuelBellomo added a commit that referenced this pull request Oct 13, 2022
* develop: (60 commits)
  fix: removing FindObjectOfType for a serialized reference (#754)
  fix: can click through loading screen [MTT-4753] (#760)
  Update CHANGELOG.md (#765)
  feat: Architecture.md update (MTT-2637) (#763)
  Update README.md (#759)
  Updating utilities package for release (#764)
  Version bumps (#761)
  Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758)
  adding components refs to index (#757)
  Adding link to feedback form at the top (#756)
  chore: adding details to changelog (#746)
  Updating readme with Typeform for feedback (#755)
  made arrow trails smaller (#750)
  Fixed up some layer settings on some archer VFX so that they show up properly! (#739)
  fix: lobby UI unblocking before it should [MTT-4579] (#748)
  feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612)
  Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753)
  fix: Moving utp to component instead of child GameObject (#752)
  Adding TOC and index to readme [MTT-4617] (#736)
  Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751)
  ...

# Conflicts:
#	Assets/Prefabs/NetworkingManager.prefab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants