Skip to content

Fix: Enabled Depth Buffer in URP Settings #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 17, 2022
Merged

Fix: Enabled Depth Buffer in URP Settings #762

merged 6 commits into from
Oct 17, 2022

Conversation

jilfranco-unity
Copy link
Contributor

Description

Enabled the depth texture in our URP assets to fix the soft particles effect on some of our particle effects, which prevents them from clipping into the ground. Also deleted some old unused URP assets.

Before:
https://user-images.githubusercontent.com/89089503/194122691-91ab8c3a-2893-4c89-b1e7-a84b4a225828.mp4

After:
https://user-images.githubusercontent.com/89089503/194122675-1ae17d1d-11ac-4e21-8913-cce32a7c39fd.mp4

Issue Number(s)

N/A

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 5, 2022
@SamuelBellomo SamuelBellomo added the DO NOT MERGE Do not merge this PR! label Oct 5, 2022
@SamuelBellomo SamuelBellomo removed the DO NOT MERGE Do not merge this PR! label Oct 6, 2022
fernando-cortez
fernando-cortez previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned offline that this could be added to the torches? Some of them seem to clip through geometry. Looks good otherwise!

@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 11, 2022
@jilfranco-unity jilfranco-unity added the 2-One More Review One review in, one to go label Oct 14, 2022
@jilfranco-unity
Copy link
Contributor Author

Mentioned offline that this could be added to the torches? Some of them seem to clip through geometry. Looks good otherwise!

This has been addressed in this PR :)

@jilfranco-unity jilfranco-unity removed the 2-Reviewed with Comments PR requires owner's attention label Oct 14, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Oct 14, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Oct 14, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Oct 14, 2022
View reviewed changes
fernando-cortez
fernando-cortez reviewed Oct 14, 2022
View reviewed changes
@jilfranco-unity jilfranco-unity merged commit e0f270b into develop Oct 17, 2022
@jilfranco-unity jilfranco-unity deleted the fix/adjusting-URP-settings branch October 17, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LPLafontaineB LPLafontaineB Awaiting requested review from LPLafontaineB

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilfranco-unity @SamuelBellomo @fernando-cortez