fix: AnticipatedNetworkVariable not updating previous value [MTTB-1036] (#3306)

This fixes the issue where the `AnticipatedNetworkVariable` previous
value was never updated on the non-authority/write permission instances
when the `OnAuthoritativeValueChanged` callback was invoked.

[MTTB-1036](https://jira.unity3d.com/browse/MTTB-1036)

Back port: #3322

## Changelog

- Fixed: Issue where the `AnticipatedNetworkVariable` previous value was
never updated on the non-authority/write permission instances when the
`OnAuthoritativeValueChanged` callback was invoked.

## Testing and Documentation

- Includes integration test
`NetworkVariableAnticipationTests.PreviousValueIsMaintainedProperly`.
- No documentation changes or additions were necessary.

<!-- Uncomment and mark items off with a * if this PR deprecates any
API:
### Deprecated API
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter
yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they
should use instead.
-->

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -15,6 +15,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Fixed
 
+- Fixed issue where `AnticipatedNetworkVariable` previous value returned by `AnticipatedNetworkVariable.OnAuthoritativeValueChanged` is updated correctly on the non-authoritative side. (#3306)
 - Fixed `OnClientConnectedCallback` passing incorrect `clientId` when scene management is disabled. (#3312)
 - Fixed issue where the `NetworkObject.Ownership` custom editor did not take the default "Everything" flag into consideration. (#3305)
 - Fixed DestroyObject flow on non-authority game clients. (#3291)

com.unity.netcode.gameobjects/Runtime/NetworkVariable/AnticipatedNetworkVariable.cs

@@ -387,6 +387,9 @@ public override void ReadField(FastBufferReader reader)
         public override void ReadDelta(FastBufferReader reader, bool keepDirtyDelta)
         {
             m_AuthoritativeValue.ReadDelta(reader, keepDirtyDelta);
+            // Assure that the post delta read is invoked in order to update
+            // previous value.
+            m_AuthoritativeValue.PostDeltaRead();
         }
     }
 }

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableAnticipationTests.cs

@@ -416,5 +416,39 @@ public void WhenStaleDataArrivesToReanticipatedVariable_ItIsAppliedAndReanticipa
             Assert.AreEqual(25, otherClientComponent.ReanticipateOnAnticipationFailVariable.Value);
             Assert.AreEqual(20, otherClientComponent.ReanticipateOnAnticipationFailVariable.AuthoritativeValue);
         }
+
+
+        private int m_PreviousSnapValue;
+        /// <summary>
+        /// Validates the previous value is being properly updated on the non-authoritative side.
+        /// </summary>
+        [Test]
+        public void PreviousValueIsMaintainedProperly()
+        {
+            var testComponent = GetTestComponent();
+
+            testComponent.SnapOnAnticipationFailVariable.OnAuthoritativeValueChanged += OnAuthoritativeValueChanged;
+            testComponent.SnapOnAnticipationFailVariable.Anticipate(10);
+            testComponent.SetSnapValueRpc(10);
+            WaitForMessageReceivedWithTimeTravel<NetworkVariableDeltaMessage>(m_ClientNetworkManagers.ToList());
+            // Verify the previous value is 0
+            Assert.AreEqual(0, m_PreviousSnapValue);
+            testComponent.SetSnapValueRpc(20);
+
+            WaitForMessageReceivedWithTimeTravel<NetworkVariableDeltaMessage>(m_ClientNetworkManagers.ToList());
+            // Verify the previous value is 10
+            Assert.AreEqual(10, m_PreviousSnapValue);
+
+            testComponent.SetSnapValueRpc(30);
+            WaitForMessageReceivedWithTimeTravel<NetworkVariableDeltaMessage>(m_ClientNetworkManagers.ToList());
+            // Verify the previous value is 20
+            Assert.AreEqual(20, m_PreviousSnapValue);
+        }
+
+        private void OnAuthoritativeValueChanged(AnticipatedNetworkVariable<int> anticipatedValue, in int previous, in int current)
+        {
+            m_PreviousSnapValue = previous;
+        }
+
     }
 }