Skip to content

Commit 8e120b0

Browse files
ci: Changed standalone tests trigger on PRs to use only Ubuntu (#3431)
It was noted that after we switched macOS from x64 to Apple Silicon the distribution times started taking up to 40m which is fine for Nightly jobs but it's frustrating for PRs triggers. We decided that coverage on Ubuntu is enough for PR trigger since all other standalone desktop devices are being tested during Nightly. ## Backport Backport present in #3432
1 parent c411130 commit 8e120b0

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.yamato/_run-all.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,12 @@ run_all_webgl_builds_6000:
138138
name: Run All WebGl Build [6000.0]
139139
dependencies:
140140
{% for project in projects.default -%}
141-
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
142141
{% for platform in test_platforms.desktop -%}
142+
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
143143
- .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_6000.0
144-
{% endfor -%}
145144
{% endif -%}
146145
{% endfor -%}
146+
{% endfor -%}
147147

148148

149149
# Runs all Desktop tests

.yamato/_triggers.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
# In order to have better coverage we run desktop standalone tests with different configurations which allows to mostly cover for different platforms, scripting backends and editor versions.
4343
# This job will FIRST run "run_quick_checks" jobs (defined in _run-all.yml) since it's the dependency of project pack jobs which is on the lowest dependency tier. This runs the fastest checks (like PVP or code standards) and ONLY IF those pass it will run the rest of the tests.
4444
# This optimization allows to speed up feedback look for any "obvious" errors and save resources.
45-
# Since standards job is a part of initial checks it's not present as direct dependency here
45+
# Since standards job is a part of initial checks it's not present as direct dependency here!!!!!!!!!!!!!!!!!!!!
4646
pull_request_trigger:
4747
name: Pull Request Trigger (develop, develop-2.0.0, & release branches)
4848
dependencies:
@@ -54,9 +54,9 @@ pull_request_trigger:
5454
- .yamato/_run-all.yml#run_all_project_tests_trunk
5555
# Run project EditMode and PLaymode project tests on minimum supported editor (6000.0 in case of NGOv2.X)
5656
- .yamato/_run-all.yml#run_all_project_tests_6000
57-
# Run standalone test with mixture of parameters to make sure there are no obvious issues with most common platform (for example --fail-on-assert option is not present with package/project tests). We run 2 different combinations with different platform/editor/scripting backend.
58-
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_mac_il2cpp_trunk
59-
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_win_mono_6000.0
57+
# Run standalone test. We run it only on Ubuntu since it's the fastest machine, and it was noted that for example distribution on macOS is taking 40m since we switched to Apple Silicon
58+
# Coverage on other standalone machines is present in Nightly job so it's enough to not run all of them for PRs
59+
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_ubuntu_il2cpp_6000.0
6060
triggers:
6161
cancel_old_ci: true
6262
pull_requests:
@@ -81,7 +81,6 @@ develop_nightly:
8181
dependencies:
8282
# Run project standards to verify package/default project
8383
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
84-
- .yamato/project-standards.yml#standards_ubuntu_testproject_6000.0
8584
# Run APV jobs to make sure the change won't break any dependants
8685
- .yamato/wrench/preview-a-p-v.yml#all_preview_apv_jobs
8786
# Run package EditMode and Playmode tests on desktop platforms on trunk and 6000.0

0 commit comments

Comments
 (0)