Skip to content

Commit c696b58

Browse files
fix: Distributed Authority codec tests not using message version (#3109)
* fix Fix issue where the CodecTestHooks was not serializing the message using the current message version. * update also updating the test project to use the release version of Unity 6 * fix When sending, always use the message version.
1 parent a115c83 commit c696b58

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/DistributedAuthorityCodecTests.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,14 @@ public IEnumerator NamedMessage()
205205
[UnityTest]
206206
public IEnumerator NetworkVariableDelta()
207207
{
208+
var component = Client.LocalClient.PlayerObject.GetComponent<TestNetworkComponent>();
208209
var message = new NetworkVariableDeltaMessage
209210
{
210-
NetworkObjectId = 0,
211-
NetworkBehaviourIndex = 1,
212-
DeliveryMappedNetworkVariableIndex = new HashSet<int> { 2, 3, 4 },
211+
NetworkObjectId = Client.LocalClient.PlayerObject.NetworkObjectId,
212+
NetworkBehaviourIndex = component.NetworkBehaviourId,
213+
DeliveryMappedNetworkVariableIndex = new HashSet<int> { 0, 1 },
213214
TargetClientId = 5,
214-
NetworkBehaviour = Client.LocalClient.PlayerObject.GetComponent<TestNetworkComponent>(),
215+
NetworkBehaviour = component,
215216
};
216217

217218
yield return SendMessage(ref message);
@@ -569,7 +570,7 @@ public IEnumerator SceneEventMessageObjectSceneChanged()
569570

570571
private IEnumerator SendMessage<T>(ref T message) where T : INetworkMessage
571572
{
572-
Client.MessageManager.SetVersion(k_ClientId, XXHash.Hash32(typeof(T).FullName), 0);
573+
Client.MessageManager.SetVersion(k_ClientId, XXHash.Hash32(typeof(T).FullName), message.Version);
573574

574575
var clientIds = new NativeArray<ulong>(1, Allocator.Temp);
575576
clientIds[0] = k_ClientId;
@@ -625,7 +626,8 @@ public void OnBeforeSendMessage<T>(ulong clientId, ref T message, NetworkDeliver
625626
}
626627

627628
var writer = new FastBufferWriter(1024, Allocator.Temp);
628-
message.Serialize(writer, 0);
629+
// Serialize the message using the known message version
630+
message.Serialize(writer, message.Version);
629631

630632
var testName = TestContext.CurrentContext.Test.Name;
631633
if (!m_ExpectedMessages.ContainsKey(testName))
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
m_EditorVersion: 6000.0.10f1
2-
m_EditorVersionWithRevision: 6000.0.10f1 (413673acabac)
1+
m_EditorVersion: 6000.0.23f1
2+
m_EditorVersionWithRevision: 6000.0.23f1 (1c4764c07fb4)

0 commit comments

Comments
 (0)