Skip to content

Commit e2ae8eb

Browse files
ci: Added tracking information to ignored tests (#3308)
This PR only modifies comments on ignored tests to track them and address those in the future via Jira Co-authored-by: Emma <[email protected]>
1 parent 84c06c7 commit e2ae8eb

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

com.unity.netcode.gameobjects/Tests/Editor/InterpolatorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void OutOfOrderShouldStillWork()
105105
Assert.That(interpolator.GetInterpolatedValue(), Is.EqualTo(2f).Within(k_Precision));
106106
}
107107

108-
[Ignore("TODO: Fix this test to still handle testing message loss without extrapolation")]
108+
[Ignore("TODO: Fix this test to still handle testing message loss without extrapolation. This is tracked in MTT-11338")]
109109
[Test]
110110
public void MessageLoss()
111111
{
@@ -306,7 +306,7 @@ public void TestUpdatingInterpolatorWithNoData()
306306
Assert.Throws<InvalidOperationException>(() => interpolator.Update(1f, serverTime));
307307
}
308308

309-
[Ignore("TODO: Fix this test to still test duplicated values without extrapolation")]
309+
[Ignore("TODO: Fix this test to still test duplicated values without extrapolation. This is tracked in MTT-11338")]
310310
[Test]
311311
public void TestDuplicatedValues()
312312
{

com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ internal class NetworkMetricsRegistrationTests
1616
.ToArray();
1717

1818
[TestCaseSource(nameof(s_MetricTypes))]
19-
[Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI.")]
19+
[Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. This ignored test is tracked in MTT-11339")]
2020
public void ValidateThatAllMetricTypesAreRegistered(Type metricType)
2121
{
2222
var dispatcher = new NetworkMetrics().Dispatcher as MetricDispatcher;

com.unity.netcode.gameobjects/Tests/Runtime/DeferredMessagingTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,6 @@ public void WhenANetworkVariableDeltaMessageArrivesBeforeASpawnArrives_ItIsDefer
495495
}
496496

497497
[Test]
498-
//[Ignore("Disabling this temporarily until it is migrated into new integration test.")]
499498
public void WhenASpawnMessageArrivesBeforeThePrefabIsAvailable_ItIsDeferred()
500499
{
501500
m_SkipAddingPrefabsToClient = true;

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransformAnticipationTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,7 @@ public AnticipatedNetworkTransform GetOtherClientComponent()
115115
}
116116

117117
[Test]
118-
// I will add this test to track in Jira as next step (after having working CI in place). The job is failing on Android
119-
[UnityPlatform(exclude = new[] { RuntimePlatform.Android })]
118+
[UnityPlatform(exclude = new[] { RuntimePlatform.Android })] // TODO: this ignored test is tracked in MTT-11341
120119
public void WhenAnticipating_ValueChangesImmediately()
121120
{
122121
var testComponent = GetTestComponent();

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2159,7 +2159,7 @@ public string ArrayStr<T>(NativeArray<T> arr) where T : unmanaged
21592159
}
21602160

21612161
[Test]
2162-
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
2162+
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
21632163
[Repeat(5)]
21642164
public void WhenSerializingAndDeserializingVeryLargeValueTypeNativeArrayNetworkVariables_ValuesAreSerializedCorrectly(
21652165

@@ -2613,7 +2613,7 @@ public string DictionaryStr<TKey, TVal>(Dictionary<TKey, TVal> list)
26132613
}
26142614

26152615
[Test]
2616-
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
2616+
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
26172617
[Repeat(5)]
26182618
public void WhenSerializingAndDeserializingVeryLargeListNetworkVariables_ValuesAreSerializedCorrectly(
26192619

@@ -2800,7 +2800,7 @@ public void WhenSerializingAndDeserializingVeryLargeListNetworkVariables_ValuesA
28002800
}
28012801

28022802
[Test]
2803-
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
2803+
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
28042804
[Repeat(5)]
28052805
public void WhenSerializingAndDeserializingVeryLargeHashSetNetworkVariables_ValuesAreSerializedCorrectly(
28062806

@@ -2956,7 +2956,7 @@ public void WhenSerializingAndDeserializingVeryLargeHashSetNetworkVariables_Valu
29562956
}
29572957

29582958
[Test]
2959-
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is unstable on mobile devices
2959+
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
29602960
[Repeat(5)]
29612961
public void WhenSerializingAndDeserializingVeryLargeDictionaryNetworkVariables_ValuesAreSerializedCorrectly(
29622962

0 commit comments

Comments
 (0)