Skip to content

fix: Removing extra bracket in UnityTransport #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2022
Merged

fix: Removing extra bracket in UnityTransport #2253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
593be61
removing extra bracket
fluong6 Oct 13, 2022
d7f9296
adding tmp commit to pass the semantic pull request check
fluong6 Oct 13, 2022
a61895d
Revert "adding tmp commit to pass the semantic pull request check"
fluong6 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,7 +1474,7 @@ public void CreateDriver(UnityTransport transport, out NetworkDriver driver,
}
else
{
m_NetworkSettings.WithSecureClientParameters(m_ClientCaCertificate, m_ServerCommonName));
m_NetworkSettings.WithSecureClientParameters(m_ClientCaCertificate, m_ServerCommonName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. How did that slip by ? :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a typo on my end when I updated to the new string-based APIs. I hadn't realized that encryption support was behind the UTP 2.0 define, so hadn't thought of trying to compile with that installed.

}
}
}
Expand Down