Skip to content

chore: remove unitytransport debug asserts [up-port] #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

This is an up-port of the adjustments made in #3213.

Changelog

NA

Testing and Documentation

  • Includes modification to the UnityTransportTests integration test.
  • No documentation changes or additions were necessary.

Replace the two places where Debug.Assert is used in UnityTransport to be DEBUG wrapped checks that log warnings as opposed to throwing asserts in order to avoid being considered a failed test run even if all tests have passed.
Cleaning up message a bit.
update to account for switching from a Debug.Assert to a Debug.LogWarning.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner February 5, 2025 14:49
@NoelStephensUnity NoelStephensUnity merged commit 05c64fa into develop-2.0.0 Feb 5, 2025
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/remove-unitytransport-debug-asserts-up-port branch February 5, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant