Skip to content

ci: [1.X] CI failures fixes and disabled tests Jira tracking informations #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 24, 2025
Merged

ci: [1.X] CI failures fixes and disabled tests Jira tracking informations #3303

merged 22 commits into from
Feb 24, 2025

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Feb 18, 2025 •
edited
Loading

This PR addresses some test failures in new CI definition (present on develop-2.0.0 branch)

  1. Code Coverage test failure --> This test was failing because packed package couldn't be find. This steams from the fact that the path was wrongly pointing to different place because package pack job was modified to fix it.
  2. minimalproject standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but minimalproject has few errors which we aim to fix in this PR
  3. testproject-tools-integration standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but testproject-tools-integration has few errors which we aim to fix in this PR
  4. testproject standards test on 2021 editor --> it seems to be only 2021 specific. For now this configuration was disabled and added for tracking
  5. Standalone builds which use combination of ubuntu and 2021 editor --> Error that happens is "No usable version of libssl". The temporary solution is to drop usage of this combination with reasons being that we still have a coverage with ubuntu on all other editors, we still have coverage of 2021 editor with win and mac and that the 2021 editor will soon be out of support
  6. Android test failures on older editors --> I'm going to investigate and if those are specific tests (and not infrastructure) then I will disable them for now since my next step after making this CI green will be to investigate all disabled tests and fix them.
  7. iOS test failures 2021 specific --> I'm going to investigate and if those are specific tests (and not infrastructure) then I will disable them for now since my next step after making this CI green will be to investigate all disabled tests and fix them
  8. Consoles build failures on 2023 editor --> Seems to be specific to 2023 editor, the errors are for example "Exception: The required GDK is not installed". I will disable console tests for 2023 editor temporarily and add it to my list to fix together with other disabled tests

@michalChrobot michalChrobot self-assigned this Feb 18, 2025
@michalChrobot michalChrobot changed the title ci: [1.X] CI failures fixes ci: [1.X] CI failures fixes and disabled tests Jira tracking informations Feb 20, 2025
@michalChrobot michalChrobot mentioned this pull request Feb 20, 2025
Merged
NoelStephensUnity and others added 5 commits February 24, 2025 10:19
@NoelStephensUnity @michalChrobot
fix
4f04730 
Fixing standards checks issues.
Fixing issue with using the upm candidates.
@NoelStephensUnity @michalChrobot
fix
40be8a8 
Adding Rider editor support for standards checks.
@NoelStephensUnity @michalChrobot
Update WaitForMetricValues.cs
4622fa9 
Fixing modifier ordering
@michalChrobot
Updated code coverage
47503b2
@michalChrobot
Merge branch 'develop' into ci-test-fixes-develop
8b65eab
@michalChrobot michalChrobot marked this pull request as ready for review February 24, 2025 09:31
@NoelStephensUnity NoelStephensUnity merged commit 94160ec into develop Feb 24, 2025
40 checks passed
@NoelStephensUnity NoelStephensUnity deleted the ci-test-fixes-develop branch February 24, 2025 20:53
@michalChrobot michalChrobot added port:2.x-needed This issue needs to be ported to 2.X branch port:2.x-completed This issue was ported to 2.X branch labels Feb 26, 2025
@michalChrobot michalChrobot mentioned this pull request Feb 27, 2025
Merged
michalChrobot added a commit that referenced this pull request Mar 21, 2025
@michalChrobot @NoelStephensUnity
ci: [NGOv1.X] Corrections of CI setup issues (#3326)
12dd5bd 
This PR focuses on fixing CI issues raised in
#3303
and before. Specifically:

1. 2023.3 editor was removed from supported list since based on official
info it transitioned into 6000 editor and 2023 editor (by itself) is not
supported. The associated ticket was (MTT-11355)
2. In case of ubuntu and 2021 editor (MTT-11354) correct version of
libssl is being installed
3. UTR command was corrected to use preinstalled UTR on the image
instead of downloading it
4. Removed upm-ci project pack definition and converted Code Coverage
test to use upm-pvp pack job
5. Simplifies some unnecessary CI commands
6. Added detailed comments regarding CI setup and commands
7. Created CI_README file which describes overall configuration
structure.
8. For macOS devices we now use M1 model (Apple Silicon) in contrast to
default x64 Intel Mac which introduced a lot of bit-flipping errors

---------

Co-authored-by: NoelStephensUnity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

@miniwolf miniwolf Awaiting requested review from miniwolf

@fluong6 fluong6 Awaiting requested review from fluong6

@EmandM EmandM Awaiting requested review from EmandM EmandM is a code owner

Assignees

@michalChrobot michalChrobot

Labels
port:2.x-completed This issue was ported to 2.X branch port:2.x-needed This issue needs to be ported to 2.X branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalChrobot @NoelStephensUnity