Skip to content

chore: [1.X] Updated CODEOWNERS file #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2025

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Mar 31, 2025

This PR updates CODEOWNERS file to mainly account for recent creation of netcode-qa group. The reasoning is:

  • @michalChrobot and @miniwolf were removed since they are part of @Unity-Technologies/netcode-qa group which was added
  • @fluong6 was removed since he's not focusing on NGO right now and we can lower the noise for him

@michalChrobot michalChrobot self-assigned this Mar 31, 2025
@michalChrobot michalChrobot changed the title chore: Updated CODEOWNERS file chore: [1.X] Updated CODEOWNERS file Mar 31, 2025
Adding additional debug information for when CorrectAmountTicksTest fails.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner March 31, 2025 21:31
@NoelStephensUnity
Copy link
Collaborator

Mac/OSX failed on CorrectAmountTicksTest so I am adding additional debug information to help us narrow down the issue. I suspect some weird rounding error as this test hasn't failed like this until the recent hardware change for Mac.

This reverts commit 1c9cb05.
@NoelStephensUnity
Copy link
Collaborator

NoelStephensUnity commented Mar 31, 2025

Removed the test update and migrated that to a separate PR: #3373 as it required an update to NetworkTime.

NoelStephensUnity added a commit that referenced this pull request Mar 31, 2025
Backport of
#3371

This PR updates CODEOWNERS file to mainly account for recent creation of
netcode-qa group. The reasoning is:

- @michalChrobot and @miniwolf were removed since they are part of
@Unity-Technologies/netcode-qa group which was added
- @fluong6 was removed since he's not focusing on NGO right now and we
can lower the noise for him

Co-authored-by: Noel Stephens <[email protected]>
@michalChrobot michalChrobot merged commit 7d20da4 into develop Apr 1, 2025
4 of 39 checks passed
@michalChrobot michalChrobot deleted the codeowners-correction-1.x branch April 1, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants