Resolving issue with breakpoints being deleted for all other than newest

files.

Added error handling to breakpoints.
Updated logging for process and player connection discovery.

Author: miniwolf

Changelog.txt

@@ -6,6 +6,18 @@ Git: https://github.com/Unity-Technologies/vscode-unity-debug
 Changes
 -------
 
+2.6.6
+=====
+ - Fix duplicate line removing breakpoints.
+
+2.6.5
+=====
+ - Initialize commands on vs code start up time.
+
+2.6.4
+=====
+ - Improve attaching to unity processes. Added support for PS4, Xbox One, and Switch.
+
 2.6.3
 =====
  - Fix regression within attach unity debugger. This is necessary when EditorInstance.json does not exist.

MonoDebug

@@ -19,7 +19,7 @@ static Log ()
 		static string FormatMessage(string message)
 		{
 			var time = DateTime.Now.ToString ("HH:mm:ss.ffffff");
-			return String.Format ("{0}: {1}\n", time, message);
+			return $"{time}: {message}\n";
 		}
 
 		public static void DebugWrite(string message)
@@ -29,7 +29,7 @@ public static void DebugWrite(string message)
 		}
 
 		public static void Write(string message)
-		{	
+		{
 			var formattedMessage = FormatMessage (message);
 			lock (logPath) {
 				File.AppendAllText (logPath, formattedMessage);

MonoDevelop.Debugger.Soft.Unity

@@ -1,7 +1,10 @@
 using System;
 using MonoDevelop.Debugger.Soft.Unity;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
+using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Text.RegularExpressions;
 
 namespace UnityDebug
@@ -44,13 +47,24 @@ public static IEnumerable<UnityProcessInfo> GetAttachableProcesses(string target
                     : UnityProcessDiscovery.GetProcessOptions.Players;
             }
 
+            Log.Write($"Trying to find all {options}");
             var processes = UnityProcessDiscovery.GetAttachableProcesses(options);
 
             processes.ForEach(p => Log.Write("Found Unity process: " + p.Name + " (" + p.Id + ")"));
 
-            return processId == -1
-                ? processes.Where(p => p.Name.Contains(processName))
-                : processes.Where(p => p.Name.Contains(processName) && p.Id == processId);
+            var resProcesses = processId == -1
+                ? processes.Where(p => p.Name.Contains(processName)).ToArray()
+                : processes.Where(p => p.Name.Contains(processName) && p.Id == processId).ToArray();
+
+            if (resProcesses.Length == 0)
+            {
+                Log.Write($"Could not find the correct process name: {targetName}");
+                Log.Write("These are the one that could be found: ");
+                processes = UnityProcessDiscovery.GetAttachableProcesses();
+                processes.ForEach(process => Log.Write($"{process.Name} : {process.Id}"));
+            }
+
+            return resProcesses;
         }
     }
 }