Attaching debugger when multiple unity processes are running will now

provide a guide on how to use the command defined in attach.js to attach
to a specific process.

Author: miniwolf

Changelog.txt

@@ -6,6 +6,10 @@ Git: https://github.com/Unity-Technologies/vscode-unity-debug
 Changes
 -------
 
+2.4.0
+=====
+ - Added support for attaching individual unity processes by use of commands.
+
 2.3.0
 =====
  - Added support for conditional breakpoints.

UnityDebug/Program.cs

@@ -85,7 +85,7 @@ static string GetUnityProcesses()
 		{
 			var processes = UnityProcessDiscovery.GetAttachableProcesses();
 
-			return string.Join("\n", processes.Select(x => x.Name));
+			return string.Join("\n", processes.Select(x => x.Name + $" ({x.Id})"));
 		}
 	}
 }

UnityDebug/UnityAttach.cs

@@ -1,6 +1,8 @@
-using MonoDevelop.Debugger.Soft.Unity;
+using System;
+using MonoDevelop.Debugger.Soft.Unity;
 using System.Collections.Generic;
 using System.Linq;
+using System.Text.RegularExpressions;
 
 namespace UnityDebug
 {
@@ -17,8 +19,15 @@ public static class UnityAttach
 		};
 
 
-		public static IEnumerable<UnityProcessInfo> GetAttachableProcesses (string targetName)
+		public static IEnumerable<UnityProcessInfo> GetAttachableProcesses(string targetName)
 		{
+			var match = Regex.Match(targetName, "\\(([0-9]+)\\)");
+			var processId = -1;
+			if (match.Success)
+			{
+				processId = Convert.ToInt32(match.Groups[1].Value);
+				targetName = targetName.Substring(0, targetName.IndexOf("(") - 1);
+			}
 			string processName;
 
 			UnityProcessDiscovery.GetProcessOptions options = UnityProcessDiscovery.GetProcessOptions.All;
@@ -36,7 +45,9 @@ public static IEnumerable<UnityProcessInfo> GetAttachableProcesses (string targe
 
 			processes.ForEach (p => Log.Write ("Found Unity process: " + p.Name + " (" + p.Id + ")"));
 
-			return processes.Where (p => p.Name.Contains (processName));
+			return processId == -1
+				? processes.Where (p => p.Name.Contains(processName))
+				: processes.Where(p => p.Name.Contains(processName) && p.Id == processId);
 		}
 	}
 }

UnityDebug/UnityDebugSession.cs

@@ -212,7 +212,7 @@ public override void Attach(Response response, dynamic args)
 
 			SendOutput("stdout", "UnityDebug: Searching for Unity process '" + name + "'");
 
-			var processes = UnityAttach.GetAttachableProcesses (name).ToArray ();
+			var processes = UnityAttach.GetAttachableProcesses(name).ToArray ();
 
 			if (processes == null) {
 				SendErrorResponse(response, 8001, "Unknown target name '{_name}'. Did you mean 'Unity Editor'?", new { _name = name});
@@ -225,9 +225,11 @@ public override void Attach(Response response, dynamic args)
 			}
 
 			if (processes.Length > 1) {
-				SendErrorResponse (response, 8002, "Multiple targets with name '{_name}' running. Unable to connect.", new { _name = name});
+				SendErrorResponse (response, 8002, "Multiple targets with name '{_name}' running. Unable to connect.\n" +
+					"Use \"Unity Attach Debugger\" from the command palette (View > Command Palette...) to specify which process to attach to.", new { _name = name});
 
-				SendOutput("stdout", "UnityDebug: Multiple targets with name '" + name + "' running. Unable to connect");
+				SendOutput("stdout", "UnityDebug: Multiple targets with name '" + name + "' running. Unable to connect.\n" +
+					"Use \"Unity Attach Debugger\" from the command palette (View > Command Palette...) to specify which process to attach to.");
 
 				foreach(var p in processes)
 					SendOutput("stdout", "UnityDebug: Found Unity process '" + p.Name + "' (" + p.Id + ")\n");

package.json

@@ -1,7 +1,7 @@
 {
   "name": "unity-debug",
   "displayName": "Debugger for Unity",
-  "version": "2.3.0",
+  "version": "2.4.0",
   "publisher": "Unity",
   "description": "Unity debugger extension",
   "engines": {