fix: Fix a build error and add a make check (#102)

Make sure that our CI runs eslint. The generate job caught some
`prefer-const` errors, which we should be able to find before a merge to
main.

Author: awalker4

.github/workflows/ci.yaml

@@ -25,6 +25,8 @@ jobs:
           node-version: 18
       - name: Install dependencies
         run: make install
+      - name: Run linter
+        run: make check
       - name: Run unit tests
         run: make test-unit
 

Makefile

@@ -22,6 +22,11 @@ install:
 build:
 	npm run build
 
+## check:					lint the client
+.PHONY: check
+check:
+	npx eslint src/
+
 #############
 # Test 		#
 #############

src/hooks/custom/utils/form.ts

@@ -92,8 +92,8 @@ export function getSplitPdfPageRange(formData: FormData, maxPages: number): [num
   const formDataParameter = formData.get(PARTITION_FORM_SPLIT_PDF_PAGE_RANGE_KEY);
   const pageRange = String(formDataParameter).split(",").map(Number)
 
-  let start = pageRange[0] || 1;
-  let end = pageRange[1] || maxPages;
+  const start = pageRange[0] || 1;
+  const end = pageRange[1] || maxPages;
 
   if (!(start > 0 && start <= maxPages) || !(end > 0 && end <= maxPages) || !(start <= end)) {
     const msg = `Page range (${start} to ${end}) is out of bounds. Values should be between 1 and ${maxPages}.`;