Update some log messages, unit test assertions

Author: awalker4

_test_unstructured_client/integration/test_decorators.py

@@ -168,12 +168,10 @@ def test_integration_split_pdf_with_page_range(
     try:
         resp = client.general.partition(req)
     except ValueError as exc:
-        if not expected_ok:
-            assert "is out of bounds." in caplog.text
-            assert "is out of bounds." in str(exc)
-            return
-        else:
-            assert exc is None
+        assert not expected_ok
+        assert "is out of bounds." in caplog.text
+        assert "is out of bounds." in str(exc)
+        return
 
     page_numbers = set([e["metadata"]["page_number"] for e in resp.elements])
 

_test_unstructured_client/unit/test_split_pdf_hook.py

@@ -427,10 +427,8 @@ def test_unit_get_page_range_returns_valid_range(page_range, expected_result):
             max_pages=20,
         )
     except ValueError as exc:
-        if not expected_result:
-            assert "is out of bounds." in str(exc) or "is not a valid page range." in str(exc)
-            return
-        else:
-            assert exc is None
+        assert not expected_result
+        assert "is out of bounds." in str(exc) or "is not a valid page range." in str(exc)
+        return
 
     assert result == expected_result

src/unstructured_client/_hooks/custom/form_utils.py

@@ -47,7 +47,7 @@ def get_page_range(form_data: FormData, key: str, max_pages: int) -> tuple[int,
     start, end = page_range
 
     if not 0 < start <= max_pages or not 0 < end <= max_pages or not start <= end:
-        msg = f"Page range {page_range} is out of bounds. Valid range is (1 - {max_pages})."
+        msg = f"Page range {page_range} is out of bounds. Start and end values should be between 1 and {max_pages}."
         logger.error(msg)
         raise ValueError(msg)
 

src/unstructured_client/_hooks/custom/split_pdf_hook.py

@@ -165,7 +165,7 @@ def before_request(
             max_pages=len(pdf.pages),
         )
 
-        page_count = min(len(pdf.pages), page_range_end - page_range_start + 1)
+        page_count = page_range_end - page_range_start + 1
         logger.info(
             "Splitting pages %d to %d (%d total)",
             page_range_start,
@@ -189,11 +189,18 @@ def before_request(
 
         pages = pdf_utils.get_pdf_pages(pdf, split_size=split_size, page_start=page_range_start, page_end=page_range_end)
         logger.info(
-            "Partitioning %d, %d-paged sets.",
-            math.ceil(page_count / split_size),
+            "Partitioning %d files with %d page(s) each.",
+            math.floor(page_count / split_size),
             split_size,
         )
 
+        # Log the remainder pages if there are any
+        if page_count % split_size > 0:
+          logger.info(
+              "Partitioning 1 file with %d page(s).",
+              page_count % split_size,
+          )
+
         async def call_api_partial(page):
             async with httpx.AsyncClient() as client:
                 status_code, json_response = await request_utils.call_api_async(