Skip to content

chore: Update usage example to be consistent with docs #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

awalker4
Copy link
Collaborator

The autogenerated example is inconsistent with our hosted docs. Remove this section and copy the usage snippet from the docs. Also, add a note for the new page range feature.

The autogenerated example is inconsistent with our hosted docs. Remove this section and copy the usage snippet from the docs. Also, add a note for the new page range feature.
@awalker4 awalker4 requested a review from Coniferish July 13, 2024 21:45
@awalker4 awalker4 marked this pull request as ready for review July 13, 2024 21:45
@awalker4 awalker4 enabled auto-merge (squash) July 13, 2024 21:47
Copy link
Contributor

@Coniferish Coniferish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But I'm also wondering if there's a way for us to continue generating this (and other examples) without them being readily findable by users so we can continue to see how the generated examples change and monitor if there are any significant changes we need to then note in our docs.

@awalker4 awalker4 merged commit f69d6d8 into main Jul 14, 2024
7 checks passed
@awalker4 awalker4 deleted the austin/readme-uodates branch July 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants