Move Split PDF page functionality to hooks #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is still missing some unit tests, I'm working on it right now, but the main functionality is finished and can be reviewed. |
src/unstructured_client/_hooks/custom/log_retries_after_error_hook.py
Outdated
Show resolved
Hide resolved
…ast page fails and other don't while splitting pdf.
|
FYI Everything with this PR is ready from my side. If there are no comments from your side then I think it can be safely merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONLY
_hooksdirectory andgen.yamlfile are relevant for review. Rest of the changes were generated by speakeasy