Adds new tests for array/dict attribute support in rewriter sections.

Author: ttjost

mlir/lib/Tools/PDLL/Parser/Parser.cpp

@@ -2882,7 +2882,7 @@ Parser::createNativeCall(SMRange loc, StringRef nativeFuncName,
 
   FailureOr<ast::Expr *> nativeFuncExpr = parseDeclRefExpr(nativeFuncName, loc);
   if (failed(nativeFuncExpr))
-    return emitError(nativeFuncName + " not found.");
+    return failure();
 
   if (!(*nativeFuncExpr)->getType().isa<ast::RewriteType>())
     return emitError(nativeFuncName + " should be defined as a rewriter.");
@@ -2892,7 +2892,7 @@ Parser::createNativeCall(SMRange loc, StringRef nativeFuncName,
   if (failed(nativeCall))
     return failure();
 
-  // Create a unique anonymous name to use, as the name for this decl is not
+  // Create a unique anonymous name declaration to use, as its name is not
   // important.
   std::string anonName =
       llvm::formatv("{0}_{1}", nativeFuncName, anonymousDeclNameCounter++)

mlir/test/mlir-pdll/Parser/expr-failure.pdll

@@ -234,9 +234,23 @@ Pattern {
   let root = op<func.func> -> ();
   // CHECK: expected '}]' in string literal
   rewrite root with {
-      let newRoot = op<func.func>() { some_array =  [{"firstAttr" = attr<"\"test\"">}, attr<"\"test\"">]} -> ();
+      let newRoot = op<func.func>() { some_array =  [{"firstAttr" = attr<"\"test\"">}, attr<"\"test\"">] } -> ();
       replace root with newRoot;
-  };;
+  };
+}
+
+// -----
+
+Rewrite addElemToArrayAttr(arrayAttr: Attr, newElement: Attr) -> Attr;
+
+Pattern {
+  let root = op<test.op> -> ();
+  let attr = attr<"\"test\"">;
+  rewrite root with {
+      // CHECK: undefined reference to `createArrayAttr`
+      let newRoot = op<test.success>() { some_array =  [ attr<"\"test\""> ]} -> ();
+      replace root with newRoot;
+  };
 }
 
 // -----

mlir/test/mlir-pdll/Parser/expr.pdll

@@ -14,6 +14,33 @@ Pattern {
 
 // -----
 
+// CHECK: |-NamedAttributeDecl {{.*}}  Name<some_array>
+// CHECK: `-UserRewriteDecl {{.*}} Name<addElemToArrayAttr> ResultType<Attr>
+// CHECK:   `Arguments`
+// CHECK:     `-CallExpr {{.*}} Type<Attr>
+// CHECK:       `-UserRewriteDecl {{.*}} Name<createArrayAttr> ResultType<Attr>
+// CHECK:     `-CallExpr {{.*}} Type<Attr>
+// CHECK:       `-UserRewriteDecl {{.*}} Name<addEntryToDictionaryAttr> ResultType<Attr>
+// CHECK:         `Arguments`
+// CHECK:           `-CallExpr {{.*}} Type<Attr>
+// CHECK:             `-UserRewriteDecl {{.*}} Name<createDictionaryAttr> ResultType<Attr>
+// CHECK:             `-AttributeExpr {{.*}} Value<""firstAttr"">
+Rewrite createDictionaryAttr() -> Attr;
+Rewrite addEntryToDictionaryAttr(dict: Attr, attrName: Attr, attr : Attr) -> Attr;
+Rewrite createArrayAttr() -> Attr;
+Rewrite addElemToArrayAttr(arrayAttr: Attr, newElement: Attr) -> Attr;
+
+Pattern {
+  let root = op<test.op> -> ();
+  let attr = attr<"\"test\"">;
+  rewrite root with {
+      let newRoot = op<test.success>() { some_array =  [ {"firstAttr" = attr<"\"test\"">}], attr} -> ();
+      replace root with newRoot;
+  };
+}
+
+// -----
+
 //===----------------------------------------------------------------------===//
 // CallExpr
 //===----------------------------------------------------------------------===//