PDLL: Parse string literals into AttributeExpr

Author: mgehre-amd

mlir/lib/Tools/PDLL/Parser/Parser.cpp

@@ -326,6 +326,7 @@ class Parser {
   FailureOr<ast::Expr *> parseMemberAccessExpr(ast::Expr *parentExpr);
   FailureOr<ast::Expr *> parseNegatedExpr();
   FailureOr<ast::Expr *> parseIntegerExpr();
+  FailureOr<ast::Expr *> parseStringExpr();
   FailureOr<ast::OpNameDecl *> parseOperationName(bool allowEmptyName = false);
   FailureOr<ast::OpNameDecl *> parseWrappedOperationName(bool allowEmptyName);
   FailureOr<ast::Expr *>
@@ -1838,6 +1839,9 @@ FailureOr<ast::Expr *> Parser::parseExpr() {
   case Token::integer:
     lhsExpr = parseIntegerExpr();
     break;
+  case Token::string:
+    lhsExpr = parseStringExpr();
+    break;
   case Token::string_block:
     return emitError("expected expression. If you are trying to create an "
                      "ArrayAttr, use a space between `[` and `{`.");
@@ -2100,6 +2104,13 @@ FailureOr<ast::Expr *> Parser::parseIntegerExpr() {
   return ast::AttributeExpr::create(ctx, loc, allocated);
 }
 
+FailureOr<ast::Expr *> Parser::parseStringExpr() {
+  SMRange loc = curToken.getLoc();
+  StringRef value = curToken.getSpelling();
+  consumeToken();
+  return ast::AttributeExpr::create(ctx, loc, value);
+}
+
 FailureOr<ast::OpNameDecl *> Parser::parseOperationName(bool allowEmptyName) {
   SMRange loc = curToken.getLoc();
 

mlir/test/mlir-pdll/Parser/expr.pdll

@@ -23,6 +23,15 @@ Pattern {
 
 // -----
 
+// CHECK: Module
+// CHECK: `-AttributeExpr {{.*}} Value<""value"">
+Pattern {
+  let attr = "value";
+  erase _: Op;
+}
+
+// -----
+
 // CHECK: |-NamedAttributeDecl {{.*}}  Name<some_array>
 // CHECK: `-UserRewriteDecl {{.*}} Name<addElemToArrayAttr> ResultType<Attr>
 // CHECK:   `Arguments`