feat: remove legalization from tosa.custom to linalg.

Author: ttjost

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

@@ -544,18 +544,6 @@ createLinalgBodyCalculationForElementwiseOp(Operation *op, ValueRange args,
     }
   }
 
-  // tosa::CustomOp
-  if (auto customOp = dyn_cast<tosa::CustomOp>(op)) {
-    // Only legalize tosa.custom_op's that are marked as implementable with
-    // 'linalg.generic' by looking at the 'implementation_attrs' attribute
-    auto implementationAttr = customOp.getImplementationAttrs();
-    if (implementationAttr == "linalg.generic") {
-      OperationState state(loc, customOp.getOperatorName(), args,
-                           resultTypes);
-      return rewriter.create(state)->getResult(0);
-    }
-  }
-
   (void)rewriter.notifyMatchFailure(
       op, "unhandled op for linalg body calculation for elementwise op");
   return nullptr;
@@ -2480,7 +2468,6 @@ void mlir::tosa::populateTosaToLinalgConversionPatterns(
       PointwiseConverter<tosa::FloorOp>,
       PointwiseConverter<tosa::ClampOp>,
       PointwiseConverter<tosa::SigmoidOp>,
-      PointwiseConverter<tosa::CustomOp>,
       IdentityNConverter<tosa::IdentityOp>,
       ReduceConverter<tosa::ReduceAllOp>,
       ReduceConverter<tosa::ReduceAnyOp>,

mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

@@ -1698,34 +1698,6 @@ func.func @table8_dyn_table(%arg0: tensor<6xi8>, %arg1: tensor<?xi8>) -> () {
 
 // -----
 
-// CHECK-LABEL: @test_custom_ops
-func.func @test_custom_ops(%arg0: tensor<1xf32>, %arg1: tensor<1xf32>) -> () {
-  // CHECK: linalg.generic
-  // CHECK: math.sin
-  // CHECK: linalg.generic
-  // CHECK: math.atan2
-  %2 = "tosa.custom"(%arg0) <{domain_name = "UNDEF", operator_name = "math.sin", implementation_attrs = "linalg.generic"}> : (tensor<1xf32>) -> tensor<1xf32>
-  %3 = "tosa.custom"(%arg0, %arg1) <{domain_name = "UNDEF", operator_name = "math.atan2", implementation_attrs = "linalg.generic"}> : (tensor<1xf32>, tensor<1xf32>) -> tensor<1xf32>
-
-  return
-}
-
-// -----
-
-// CHECK-LABEL: @test_custom_ops_dyn
-func.func @test_custom_ops_dyn(%arg0: tensor<?xf32>, %arg1: tensor<?xf32>) -> () {
-  // CHECK: linalg.generic
-  // CHECK: math.cos
-  // CHECK: linalg.generic
-  // CHECK: math.atan2
-  %2 = "tosa.custom"(%arg0) <{domain_name = "UNDEF", operator_name = "math.cos", implementation_attrs = "linalg.generic"}> : (tensor<?xf32>) -> tensor<?xf32>
-  %3 = "tosa.custom"(%arg0, %arg1) <{domain_name = "UNDEF", operator_name = "math.atan2", implementation_attrs = "linalg.generic"}> : (tensor<?xf32>, tensor<?xf32>) -> tensor<?xf32>
-
-  return
-}
-
-// -----
-
 // CHECK: #[[$MAP0:.*]] = affine_map<(d0, d1, d2, d3, d4) -> (d0, d3, d4)>
 // CHECK: #[[$MAP1:.*]] = affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2)>