make DenySettingsMode required in new/set commands

Author: dantedallag

src/Resources/ResourceManager/Implementation/DeploymentStacks/NewAzManagementGroupDeploymentStack.cs

@@ -128,11 +128,7 @@ public class NewAzManagementGroupDeploymentStack : DeploymentStacksCmdletBase
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack ResourceGroups after updating stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
 
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
-
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/Implementation/DeploymentStacks/NewAzResourceGroupDeploymentStack.cs

@@ -124,12 +124,8 @@ public class NewAzResourceGroupDeploymentStack : DeploymentStacksCmdletBase
 
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack ResourceGroups after updating stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
-
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
 
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/Implementation/DeploymentStacks/NewAzSubscriptionDeploymentStack.cs

@@ -123,11 +123,7 @@ public class NewAzSubscriptionDeploymentStack : DeploymentStacksCmdletBase
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack resource groups after updating stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
 
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
-
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/Implementation/DeploymentStacks/SetAzManagmentGroupDeploymentStack.cs

@@ -134,11 +134,7 @@ public class SetAzManagementGroupDeploymentStack : DeploymentStacksCmdletBase
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack ResourceGroups after deleting stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
 
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
-
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/Implementation/DeploymentStacks/SetAzResourceGroupDeploymentStack.cs

@@ -126,12 +126,7 @@ public class SetAzResourceGroupDeploymentStack : DeploymentStacksCmdletBase
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack ResourceGroups after deleting stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
 
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
-
-
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/Implementation/DeploymentStacks/SetAzSubscriptionDeploymentStack.cs

@@ -127,11 +127,7 @@ public class SetAzSubscriptionDeploymentStack : DeploymentStacksCmdletBase
         [Parameter(Mandatory = false, HelpMessage = "Signal to delete unmanaged stack ResourceGroups after deleting stack.")]
         public SwitchParameter DeleteResourceGroups { get; set; }
 
-        // Not Yet Supported.
-        /*[Parameter(Mandatory = false, HelpMessage = "Singal to delete unmanaged stack management groups after updating stack.")]
-        public SwitchParameter DeleteManagementGroups { get; set; }*/
-
-        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        [Parameter(Mandatory = true, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
         public PSDenySettingsMode DenySettingsMode { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]

src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs

@@ -394,7 +394,7 @@ public PSDeploymentStack ResourceGroupCreateOrUpdateDeploymentStack(
             Hashtable tags
             )
         {
-            var actionOnUnmanage = new DeploymentStackPropertiesSharedActionOnUnmanage
+            var actionOnUnmanage = new DeploymentStackPropertiesActionOnUnmanage
             {
                 Resources = resourcesCleanupAction,
                 ResourceGroups = resourceGroupsCleanupAction,
@@ -519,7 +519,7 @@ public PSDeploymentStack SubscriptionCreateOrUpdateDeploymentStack(
             Hashtable tags
         )
         {
-            var actionOnUnmanage = new DeploymentStackPropertiesSharedActionOnUnmanage
+            var actionOnUnmanage = new DeploymentStackPropertiesActionOnUnmanage
             {
                 Resources = resourcesCleanupAction,
                 ResourceGroups = resourceGroupsCleanupAction,
@@ -630,7 +630,7 @@ public PSDeploymentStack ManagementGroupCreateOrUpdateDeploymentStack(
             Hashtable tags
         )
         {
-            var actionOnUnmanage = new DeploymentStackPropertiesSharedActionOnUnmanage
+            var actionOnUnmanage = new DeploymentStackPropertiesActionOnUnmanage
             {
                 Resources = resourcesCleanupAction,
                 ResourceGroups = resourceGroupsCleanupAction,