Fix the issue of compare type with API version in namespace (Azure#16363)

Co-authored-by: wyunchi-ms <[email protected]>

Author: wyunchi-ms

tools/StaticAnalysis/BreakingChangeAnalyzer/TypeMetadataHelper.cs

@@ -101,6 +101,8 @@ public bool CompareTypeMetadata(
                         continue;
                     }
 
+                    oldPropertyType = oldTypeMetadata.GetClassNameWithoutApiVersion(oldPropertyType);
+                    newPropertyType = newTypeMetadata.GetClassNameWithoutApiVersion(newPropertyType);
                     // If the types are the same, compare their properties
                     if (oldPropertyType.Equals(newPropertyType, StringComparison.OrdinalIgnoreCase))
                     {
@@ -237,7 +239,9 @@ public void CheckParameterType(
             }
 
             // If the types are different, log an issue
-            if (!oldTypeMetadata.Name.Equals(newTypeMetadata.Name, StringComparison.OrdinalIgnoreCase))
+            string oldTypeName = oldTypeMetadata.GetClassNameWithoutApiVersion(oldTypeMetadata.Name);
+            string newTypeName = newTypeMetadata.GetClassNameWithoutApiVersion(newTypeMetadata.Name);
+            if (!oldTypeName.Equals(newTypeName, StringComparison.OrdinalIgnoreCase))
             {
                 issueLogger?.LogBreakingChangeIssue(
                     cmdlet: cmdlet,
@@ -313,8 +317,10 @@ private bool IsElementType(
             // Check if the type is an array
             if (oldTypeMetadata.ElementType != null && newTypeMetadata.ElementType != null)
             {
+                string oldTypeName = oldTypeMetadata.GetClassNameWithoutApiVersion(oldTypeMetadata.ElementType);
+                string newTypeName = newTypeMetadata.GetClassNameWithoutApiVersion(newTypeMetadata.ElementType);
                 // Check if the element of the array is the same in the old and new metadata
-                if (oldTypeMetadata.ElementType.Equals(newTypeMetadata.ElementType, StringComparison.OrdinalIgnoreCase))
+                if (oldTypeName.Equals(newTypeName, StringComparison.OrdinalIgnoreCase))
                 {
                     // If we have not previously seen this element type,
                     // run this method on the type
@@ -431,7 +437,9 @@ private bool HasSameGenericType(
             ReportLogger<BreakingChangeIssue> issueLogger)
         {
             // If the type of the generics are the same, return true
-            if (oldTypeMetadata.Name.Equals(newTypeMetadata.Name, StringComparison.OrdinalIgnoreCase))
+            string oldTypeName = oldTypeMetadata.GetClassNameWithoutApiVersion(oldTypeMetadata.Name);
+            string newTypeName = newTypeMetadata.GetClassNameWithoutApiVersion(newTypeMetadata.Name);
+            if (oldTypeName.Equals(newTypeName, StringComparison.OrdinalIgnoreCase))
             {
                 return true;
             }

tools/Tools.Common/Models/TypeMetadata.cs

@@ -217,7 +217,7 @@ public TypeMetadata(Type inputType)
 
         public List<MethodSignature> Constructors { get { return _constructors; } }
 
-        private string GetClassNameWithoutApiVersion(string className)
+        public string GetClassNameWithoutApiVersion(string className)
         {
             var matcher = Regex.Match(className, @"Microsoft\.Azure\.PowerShell\.Cmdlets\.([\w\.]+)\.Api[\w\d]+\.([\w\.]+)");
             if (!matcher.Success || matcher.Groups.Count < 3)