Fix Get-subscription cmdlets

Author: Xynoclafe

src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzSubscriptionDeploymentStack.cs renamed to src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzDeploymentStack.cs

@@ -1,16 +1,30 @@
-using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
-using Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels;
-using System;
-using System.Collections.Generic;
-using System.Management.Automation;
-using System.Text;
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
 
 namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
 {
-    [Cmdlet("Get", Common.AzureRMConstants.AzureRMPrefix + "SubscriptionDeploymentStack",
-        DefaultParameterSetName = GetAzSubscriptionDeploymentStack.ListParameterSetname), OutputType(typeof(PSDeploymentStack))]
-    [Alias("Get-AzDeploymentStack")]
-    class GetAzSubscriptionDeploymentStack : DeploymentStacksCmdletBase
+    using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
+    using Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels;
+    using System;
+    using System.Collections.Generic;
+    using System.Management.Automation;
+    using System.Text;
+
+    [Cmdlet("Get", Common.AzureRMConstants.AzureRMPrefix + "DeploymentStack",
+        DefaultParameterSetName = GetAzDeploymentStack.ListParameterSetname), OutputType(typeof(PSDeploymentStack))]
+    [Alias("Get-AzSubscriptionDeploymentStack")]
+    public class GetAzDeploymentStack : DeploymentStacksCmdletBase
     {
         #region Cmdlet Parameters and Parameter Set Definitions
 

src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzSubscriptionDeploymentStackSnapshot.cs renamed to src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzDeploymentStackSnapshot.cs

@@ -1,15 +1,30 @@
-using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
-using Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels;
-using System;
-using System.Collections.Generic;
-using System.Management.Automation;
-using System.Text;
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
 
 namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
 {
-    [Cmdlet("Get", Common.AzureRMConstants.AzureRMPrefix + "SubscriptionDeploymentStackSnapshot",
-        DefaultParameterSetName = GetAzSubscriptionDeploymentStackSnapshot.ListParameterSetname), OutputType(typeof(PSDeploymentStackSnapshot))]
-    class GetAzSubscriptionDeploymentStackSnapshot : DeploymentStacksCmdletBase
+    using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
+    using Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels;
+    using System;
+    using System.Collections.Generic;
+    using System.Management.Automation;
+    using System.Text;
+
+    [Cmdlet("Get", Common.AzureRMConstants.AzureRMPrefix + "DeploymentStackSnapshot",
+        DefaultParameterSetName = GetAzDeploymentStackSnapshot.ListParameterSetname), OutputType(typeof(PSDeploymentStackSnapshot))]
+    [Alias("Get-AzSubscriptionDeploymentStackSnapshot")]
+    public class GetAzDeploymentStackSnapshot : DeploymentStacksCmdletBase
     {
         #region Cmdlet Parameters and Parameter Set Definitions
 
@@ -39,7 +54,7 @@ class GetAzSubscriptionDeploymentStackSnapshot : DeploymentStacksCmdletBase
         #endregion
 
         #region Cmdlet Overrides
-        
+
         public override void ExecuteCmdlet()
         {
             try
@@ -69,5 +84,6 @@ public override void ExecuteCmdlet()
         }
 
         #endregion
+
     }
 }

src/Resources/ResourceManager/SdkModels/DeploymentStacks/PSDeploymentStack.cs

@@ -56,7 +56,7 @@ internal PSDeploymentStack(DeploymentStack deploymentStack)
             this.id = deploymentStack.Id;
             this.name = deploymentStack.Name;
             this.type = deploymentStack.Type;
-            this.creationTime = deploymentStack.SystemData.CreatedAt;
+            this.creationTime = (deploymentStack.SystemData != null) ? deploymentStack.SystemData.CreatedAt : null;
             this.location = deploymentStack.Location;
             this.template = deploymentStack.Template;
             this.templateLink = deploymentStack.TemplateLink;

src/Resources/Resources.Test/ScenarioTests/DeploymentStackTests.ps1

@@ -156,6 +156,4 @@ function Test-GetSubscriptionDeploymentStack
         # Cleanup
         Clean-DeploymentAtSubscription $rname
     }
-}
-
-function 
+}

src/Resources/Resources/Az.Resources.psd1

@@ -153,12 +153,12 @@ CmdletsToExport = 'Get-AzProviderOperation', 'Remove-AzRoleAssignment',
                'Get-AzTenantDeploymentWhatIfResult', 'Get-AzTemplateSpec', 
                'New-AzTemplateSpec', 'Set-AzTemplateSpec', 'Export-AzTemplateSpec', 
                'Remove-AzTemplateSpec', 'Get-AzResourceGroupDeploymentStack',
-               'Get-AzResourceGroupDeploymentStackSnapshot', 'Get-AzSubscriptionDeploymentStack',
-               'Get-AzSubscriptionDeploymentStackSnapshot', 'New-AzResourceGroupDeploymentStack',
+               'Get-AzResourceGroupDeploymentStackSnapshot',
+               'New-AzResourceGroupDeploymentStack',
                'New-AzSubscriptionDeploymentStack', 'Remove-AzResourceGroupDeploymentStack',
                'Remove-AzResourceGroupDeploymentStackSnapshot', 'Remove-AzSubscriptionDeploymentStack',
                'Remove-AzSubscriptionDeploymentStackSnapshot', 'Set-AzResourceGroupDeploymentStack',
-               'Set-AzSubscriptionDeploymentStack'
+               'Set-AzSubscriptionDeploymentStack', 'Get-AzDeploymentStack', 'Get-AzDeploymentStackSnapshot'
 
 # Variables to export from this module
 # VariablesToExport = @()
@@ -174,7 +174,9 @@ AliasesToExport = 'Get-AzResourceProviderAction',
                'Stop-AzSubscriptionDeployment', 
                'Save-AzSubscriptionDeploymentTemplate', 
                'Get-AzSubscriptionDeploymentOperation', 
-               'Get-AzSubscriptionDeploymentWhatIfResult'
+               'Get-AzSubscriptionDeploymentWhatIfResult',
+               'Get-AzSubscriptionDeploymentStack',
+               'Get-AzSubscriptionDeploymentStackSnapshot'
 
 # DSC resources to export from this module
 # DscResourcesToExport = @()