Stacks now outputs errors correctly, 2 tests failing

Author: harshpatel17

src/Resources/ResourceManager/Implementation/Deployments/GetAzureSubscriptionDeploymentCmdlet.cs

@@ -55,7 +55,7 @@ protected override void OnProcessRecord()
             {
                 DeploymentName = this.Name ?? (string.IsNullOrEmpty(this.Id) ? null : ResourceIdUtility.GetResourceName(this.Id))
             };
-
+            
             WriteObject(ResourceManagerSdkClient.FilterDeployments(options), true);
         }
     }

src/Resources/ResourceManager/Properties/Resources.Designer.cs

@@ -469,6 +469,9 @@
   <data name="DeploymentOperationOuterError" xml:space="preserve">
     <value>The deployment '{0}' failed with error(s). Showing {1} out of {2} error(s).</value>
   </data>
+  <data name="DeploymentStackOperationOuterError" xml:space="preserve">
+    <value>The deployment '{0}' failed with error(s). Showing {1} out of {2} error(s).</value>
+  </data>
   <data name="DeploymentOperationErrorMessageNoDetails" xml:space="preserve">
     <value>{0} (Code:{1})</value>
   </data>

src/Resources/ResourceManager/Properties/Resources.resx

@@ -25,6 +25,8 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkClient
 {
     public class DeploymentStacksSdkClient
     {
+        public const string ErrorFormat = "Error: Code={0}; Message={1}\r\n";
+
         public IDeploymentStacksClient DeploymentStacksClient { get; set; }
 
         public Action<string> VerboseLogger { get; set; }
@@ -369,6 +371,7 @@ string updateBehavior
                 "Failed",
                 "Canceled"
                 );
+            errorValidation(finalStack);
             return new PSDeploymentStack(finalStack);
         }
 
@@ -505,9 +508,31 @@ string deploymentScope
                 "Canceled"
                 );
 
+
+            errorValidation(finalStack);
+
             return new PSDeploymentStack(finalStack);
         }
 
+        private void errorValidation(DeploymentStack deploymentStack)
+        {
+            if (deploymentStack.Error != null)
+            {
+                var error = deploymentStack.Error;
+                var sb = new StringBuilder();
+                List<string> errorMessages = processErrorMessages(error);
+                sb.AppendFormat(ProjectResources.DeploymentStackOperationOuterError, deploymentStack.Name, errorMessages.Count, errorMessages.Count);
+                sb.AppendLine();
+
+                foreach (string message in errorMessages)
+                {
+                   sb.AppendLine(message);
+                }
+
+                WriteError(sb.ToString());
+            }
+        }
+
         private DeploymentStack waitStackCompletion(Func<Task<AzureOperationResponse<DeploymentStack>>> getStack, params string[] status)
         {
             //Poll stack deployment based on RetryAfter. If no RetyrAfter is present, polling status in two phases.
@@ -613,6 +638,7 @@ string description
             }
 
             var deploymentStack = DeploymentStacksClient.DeploymentStacks.BeginCreateOrUpdateAtResourceGroup(resourceGroupName, deploymentStackName, deploymentStackModel);
+            errorValidation(deploymentStack);
             return new PSDeploymentStack(deploymentStack);
         }
 
@@ -639,5 +665,42 @@ private void WriteError(string error)
                 ErrorLogger(error);
             }
         }
+
+        private List<string> processErrorMessages(ErrorResponse error)
+        {
+            List<string> errorMessages = new List<string>();
+
+            Stack<ErrorResponse> stack = new Stack<ErrorResponse>();
+            stack.Push(error);
+
+            while (stack.Count > 0)
+            {
+                var currentError = stack.Pop();
+                errorMessages.Add(string.Format(ErrorFormat, currentError.Code, currentError.Message));
+                if (currentError.Details != null)
+                {
+                    foreach (ErrorResponse detail in currentError.Details)
+                    {
+                        stack.Push(detail);
+                    }
+                }
+            }
+
+
+            //while length of count of error > 2
+                //loop through all details
+
+            /*while (error.Details != null && error.Details.Count >= 0)
+            {
+                errorMessages.Add(string.Format(ErrorFormat, error.Code, error.Message));
+                if (error.Details.Count == 0)
+                {
+                    break;
+                }
+                error = error.Details[0];
+            }*/
+
+            return errorMessages;
+        }
     }
 }

src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs

@@ -1469,7 +1469,7 @@ private DeploymentExtended ExecuteDeploymentInternal(PSDeploymentCmdletParameter
             this.BeginDeployment(parameters, deployment);
 
             WriteVerbose(string.Format(ProjectResources.CreatedDeployment, parameters.DeploymentName));
-
+            
             return ProvisionDeploymentStatus(parameters, deployment);
         }
 

src/Resources/ResourceManager/SdkClient/ResourceManagerSdkClient.cs

@@ -63,7 +63,7 @@ public static PSDeployment ToPSDeployment(this DeploymentExtended result, string
             {
                 deployment = CreatePSDeployment(result, managementGroupId, resourceGroupName);
             }
-
+            
             return deployment;
         }